[experimental] Native file dragging plugin #1584
Draft
+122
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 313af6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yf-yang
commented
Jan 7, 2025
yf-yang
commented
Jan 7, 2025
yf-yang
commented
Jan 7, 2025
yf-yang
commented
Jan 7, 2025
| "build:core": "tsup src/core/index.ts", | ||
| "build:modifiers": "tsup --entry.modifiers src/modifiers/index.ts", | ||
| "build:plugins": "tsup --entry.debug src/plugins/debug/index.ts --outDir ./plugins", | ||
| "build:draggableFile": "tsup --entry.draggableFile src/plugins/draggableFile/index.ts --outDir ./plugins", |
There was a problem hiding this comment.
Didn't take times figuring out how to configure the command. Put it here for now
This comment was marked as resolved.
This comment was marked as resolved.
yf-yang
changed the title
yf-yang
commented
Jan 8, 2025
|
|
||
| if (!status.initialized || !shape) { | ||
| if (!status.initialized) { | ||
| return DEFAULT_VALUE; |
There was a problem hiding this comment.
It should be collision detection algorithm's responsibility to check shape's availability. File draggable does not have a shape and would be filtered by the original code implementation
yf-yang
commented
Jan 8, 2025
yf-yang
commented
Jan 8, 2025
| // Make sure effects will re-run when those properties change | ||
| void position.current; | ||
| void shape; | ||
|
|
There was a problem hiding this comment.
I don't know if it has a performance penalty (too many collisions recompute?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at providing a plugin to drag and drop file from native fs to browser.
It is marked as draft because:
I don't know how to fix it. Would you consider passing the DOM event to core dnd-kit events (dragstart, dragend, dragmove...)?
fixes #1581