Added support for Google Hangouts Chat #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks cool. I'll test it during the weekend and merge or comment. P.S. Sorry for the late reply. |
|
@matthewdickinson I need some help with setting up a chatbot. Can you write a short instructions how to do that? I created a bot as described here, but I can't activate the bot. Also, I got credentials for the chatbot, do I need to use them somehow? |
stojanovic
reviewed
Sep 26, 2018
| @@ -68,6 +69,9 @@ module.exports = function botBuilder(messageHandler, options, optionalLogError) | |||
| if (isEnabled('alexa')) { | |||
| alexaSetup(api, messageHandlerPromise, logError); | |||
| } | |||
| if (isEnabled('google-hangouts-chat')) { | |||
There was a problem hiding this comment.
I think we should use just hangouts because it's shorter but still describes the platform uniquely.
|
|
||
| module.exports = function googleHangoutsSetup(api, bot, logError, optionalParser, optionalResponder) { | ||
| let parser = optionalParser || googleHangoutsParse; | ||
| let responder = optionalResponder || googleHangoutsReply; |
There was a problem hiding this comment.
We can use const instead of let for both parser and responder, as they are not re-assigned. I guess should update that for other bots too.
| expect(parse({message: {}})).toBeUndefined(); | ||
| }); | ||
| it('should return original request with an empty text if the intent is missing', () => { | ||
| let msg = {message: {foo: 'bar'}, type: 'ADDED_TO_SPACE'}; |
There was a problem hiding this comment.
msg is never re-assigned, use const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic support for the Google Hangouts Chat protocol.