Skip to content

fix(mosaic): keep enterprise account icons visible in dark mode - #10377

Open
austincalvelage wants to merge 1 commit into
mainfrom
austin/enterprise-account-dark-mode-fix
Open

austincalvelage wants to merge 1 commit into
mainfrom
austin/enterprise-account-dark-mode-fix

Conversation

@austincalvelage

@austincalvelage austincalvelage commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Description

Make monochrome enterprise-account logos, including Okta, follow the text color so they remain visible in dark mode. Apply the same provider recognition and shared icon rendering used by connected accounts and Web3 wallets to both linked accounts and available enterprise connections.

Open the enterprise-account examples in Swingset and toggle dark mode to compare the Okta logo. Colored provider logos retain their original colors.

Before After
Before After

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eed488e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 23, 2026 12:55am UTC
swingset Ready Ready Preview Oct 23, 2026 12:55am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 17eecac and eed488e.

📒 Files selected for processing: 8
  • .changeset/tidy-enterprise-icons.md
  • packages/mosaic/src/features/user-profile/user-profile-enterprise-accounts-section/__tests__/user-profile-enterprise-accounts-projection.test.ts
  • packages/mosaic/src/features/user-profile/user-profile-enterprise-accounts-section/user-profile-enterprise-account-row.view.tsx
  • packages/mosaic/src/features/user-profile/user-profile-enterprise-accounts-section/user-profile-enterprise-accounts-section.model.ts
  • packages/mosaic/src/features/user-profile/user-profile-enterprise-accounts-section/user-profile-enterprise-accounts-section.styles.ts
  • packages/mosaic/src/features/user-profile/user-profile-enterprise-accounts-section/user-profile-enterprise-accounts-section.types.ts
  • packages/mosaic/src/features/user-profile/user-profile-provider.utils.ts
  • packages/swingset/src/stories/fixtures/user-profile-enterprise-accounts.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

💤 Files with no reviewable changes: 1
  • packages/mosaic/src/features/user-profile/user-profile-enterprise-accounts-section/user-profile-enterprise-accounts-section.styles.ts

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.

📝 Walkthrough

Enterprise account and connection projections now include a monochromeIcon value based on normalized provider names. The provider list now includes okta. The account row delegates icon and fallback rendering to UserProfileProviderMedia. Projection tests cover four providers, and the story fixture preserves connection fields when creating a linked account.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: alexcarpenter, ephem

Merge Risk: ⚪ Minimal · up to eed48

The icon changes are ready to merge after normal checks; no actionable merge-blocking issue remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 6 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: keeping enterprise account icons visible in dark mode.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description directly explains the changes to monochrome enterprise-account logos, Okta provider recognition, shared icon rendering, and dark-mode visibility. It matches the changeset.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 6 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10377

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10377

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10377

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10377

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10377

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10377

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10377

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10377

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10377

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10377

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10377

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10377

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10377

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10377

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10377

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10377

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10377

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10377

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10377

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10377

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10377

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10377

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10377

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10377

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10377

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10377

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10377

commit: eed488e

This branch was successfully deployed

2 active deployments
Preview – swingset — eed488ec Deployed Oct 23, 2026 by vercel[bot]
Preview – clerk-js-sandbox — eed488ec Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant