-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let clojure-ts-mode derive from clojure-mode for Emacs 30+ #53
Conversation
3a4e694
to
f348d03
Compare
@@ -966,6 +966,9 @@ See `clojure-ts--font-lock-settings' for usage of MARKDOWN-AVAILABLE." | |||
(when (fboundp 'transpose-sexps-default-function) | |||
(setq-local transpose-sexps-function #'transpose-sexps-default-function))))) | |||
|
|||
(when (fboundp #'derived-mode-add-parents) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding a comment here explaining this, given that this API is fairly new and unknown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I've done.
Emacs 30 defines the function `derived-mode-add-parents` that is used for the built-in *-ts-mode, this will make (provided-mode-derived-p 'clojure-ts-mode 'clojure-mode) return true just like other treesit major modes.
f348d03
to
fe1b9ea
Compare
Seems this change broke the CI's lint check. Please, take a look at the build failure when you can. |
Is this part of the problem?
|
I don't think so. Most like we're not running the lint job on Emacs 30, and this results in:
|
Although I thought that the use of |
For some reasons removing the I tested locally with |
Yeah, it seems this has to be a regular symbol. I'll apply the fix now. |
Emacs 30 defines the function
derived-mode-add-parents
that is used for the built-in *-ts-mode, this will make(provided-mode-derived-p 'clojure-ts-mode 'clojure-mode)
return true just like other treesit major modes.Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdoc
and fixed any warnings in the code you've written.