Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing await #7709

Merged
merged 1 commit into from
Jan 9, 2025
Merged

test: add missing await #7709

merged 1 commit into from
Jan 9, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 9, 2025

Fixes a warning in CI logs.

The warning warns that this will not work with Vitest3


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: fixtures
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test onlu

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 997c05d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vicb vicb requested a review from petebacondarwin January 9, 2025 12:21
Copy link
Contributor

github-actions bot commented Jan 9, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-wrangler-7709

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7709/npm-package-wrangler-7709

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-wrangler-7709 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-cloudflare-workers-bindings-extension-7709 -O ./cloudflare-workers-bindings-extension.0.0.0-v930f009fd.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v930f009fd.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-create-cloudflare-7709 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-cloudflare-kv-asset-handler-7709
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-miniflare-7709
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-cloudflare-pages-shared-7709
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-cloudflare-unenv-preset-7709
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-cloudflare-vitest-pool-workers-7709
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-cloudflare-workers-editor-shared-7709
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-cloudflare-workers-shared-7709
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12689768228/npm-package-cloudflare-workflows-shared-7709

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.0
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit 183a7ba into main Jan 9, 2025
34 of 36 checks passed
@penalosa penalosa deleted the vb-branch-resolves branch January 9, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants