Repository navigation
stop empty-string space key leaking orphaned policies - #376
Merged
Merged
Conversation
filter() looked up subjectSpaces[appSpaces[id]]. An app deleted from Cloud Controller is absent from appSpaces, so the lookup yielded "". GetSubjectSpaces added "" to subjectSpaces for org-scoped roles (relationships.space.data null), so policies with a deleted endpoint passed filter() for any non-admin user holding an org role. - filter(): use comma-ok lookups and skip any policy whose source or destination app is missing from appSpaces or maps to an empty space. - GetSubjectSpaces: skip roles with an empty space GUID and log at debug level. - Add regression tests for both paths, plus the SubjectSpacesWithNullSpace fixture. Release note: Non-admin users with org-level roles no longer see policies whose source or destination app has been deleted from Cloud Controller. ai-assisted=yes TNZGOV-102 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
geofffranks
approved these changes
Oct 19, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filter() looked up subjectSpaces[appSpaces[id]]. An app deleted from Cloud Controller is absent from appSpaces, so the lookup yielded "". GetSubjectSpaces added "" to subjectSpaces for org-scoped roles (relationships.space.data null), so policies with a deleted endpoint passed filter() for any non-admin user holding an org role.
Release note: Non-admin users with org-level roles no longer see policies whose source or destination app has been deleted from Cloud Controller.
JIRA: https://vmw-jira.broadcom.net/browse/TNZGOV-102
Backward Compatibility
Breaking Change? No