Issues/43 incidents seed

[socialskillsforitpeople]

Fixes #43

[RaduCStefanescu]

@claudiunicolaa could you please help with a review?
@socialskillsforitpeople thank you for the PR!

[claudiunicolaa]

Please, use camelCase notation ($incidentTypeIds).

[claudiunicolaa]

If in IncidentTypesTableSeeder one of the types change the id value this seeder can introduce invalid data / throw a foreign key error.
I suggest using in IncidentTypesTableSeeder an array const

const DATA = [
    [
        'id'    => 1,
        'label' => 'IT_OTHER',
        'code'  => 'OTH',
        'name'  => 'Altul'
    ],
.....
    [
        'id'    => 12,
        'label' => 'VOTE',
        'code'  => 'NUM',
        'name'  => 'Probleme în zilele votului'
    ]
];

iterate over DATA and insert

        foreach (self::DATA as $datum) {
            IncidentType::create($datum);
        }

in a static method iterate to obtain the ids

    public static function getIds()
    {
        $ids = [];
        foreach (self::DATA as $datum) {
            $ids[] = $datum['id'];
        }
        return $ids;
    }

and in IncidentsTableSeeder you can use the IncidentTypesTableSeeder::getIds() method.

It is just an idea. Ping me on slack (username: claudiunicolaa) if you have questions.

[RaduCStefanescu]

Just a noob question, can we query for the IncidentType ids in the IncidentsTableSeeder? Because that will solve all our problems.
I agree with @claudiunicolaa the current solution is not ideal, so I will mark it as Needs work.

[RaduCStefanescu]

Hints in the comments.

[claudiunicolaa]

Just a noob question, can we query for the IncidentType ids in the IncidentsTableSeeder? Because that will solve all our problems.
I agree with @claudiunicolaa the current solution is not ideal, so I will mark it as Needs work.

It is possible to query IncidentType in IncidentsTableSeeder.

[socialskillsforitpeople]

@claudiunicolaa Added a variable instead of a constant because of php constratints
@RaduCStefanescu @costeaalex updated as requested
@RaduCStefanescu we can of course also query DB. I prefer to keep it without this query because there are no other places in seeders where we are actually querying the DB. Also, since we now have this variable we don't need to call the db because we already have the data in the code.

Sorry for the long wait!