Od/chore/casing for git provider #2901
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholas-codecov
approved these changes
May 28, 2024
nicholas-codecov
requested changes
May 28, 2024
There was a problem hiding this comment.
Whoops, seems like there's an error with one of the tests, can you take a peak at that @sashaboi ?
|
@nicholas-codecov would the recent changes work? tests seem to pass 👍 |
|
Sorry @sashaboi, was ooo the past couple days. Taking a peak now 👀 |
nicholas-codecov
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes codecov/engineering-team#630
Replaces the correct cases for git providers.
On my local setup all tests seem to pass, and I have modified quite a few as well, could we please run tests to see if everything is in order @nicholas-codecov ?
Notable Changes
Changes in the way
provider.jshandles things, please have a lookLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.