Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call ta processors using chain #966

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

we don't want to call the ta processors using a chord because we want to temporarily reduce the amount of lock contention in the database

this is a short term fix, we eventually want to move the test results writes to the finisher step, which will achieve the same effect as this fix

we don't want to call the ta processors using a chord because we want to
temporarily reduce the amount of lock contention in the database

this is a short term fix, we eventually want to move the test results
writes to the finisher step, which will achieve the same effect as this
fix
@joseph-sentry joseph-sentry requested a review from a team December 18, 2024 17:29
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (7b243ab) to head (72291ff).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #966   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         443      443           
  Lines       35819    35820    +1     
=======================================
+ Hits        35096    35097    +1     
  Misses        723      723           
Flag Coverage Δ
integration 42.16% <100.00%> (-0.01%) ⬇️
unit 90.63% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 4064bb5 Dec 18, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/ta-process-chain branch December 18, 2024 17:44
Copy link

sentry-io bot commented Dec 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: unsupported operand type(s) for |: '_chain' and 'list' app.tasks.upload.Upload View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants