Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update shared #995

Merged
merged 1 commit into from
Jan 8, 2025
Merged

chore: update shared #995

merged 1 commit into from
Jan 8, 2025

Conversation

giovanni-guidini
Copy link
Contributor

Updates shared to codecov/shared#463 Which includes some changes to the tokens generated when we pull info for git providers. Hence, we need some test changes to reflect the new info.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

github-actions bot commented Jan 8, 2025

This PR includes changes to shared. Please review them here: codecov/shared@b186b3c...609e56d

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2025

❌ 12 Tests Failed:

Tests completed Failed Passed Skipped
12 12 0 0
View the top 3 failed tests by shortest run time
tasks/tests/integration/test_ghm_sync_plans.py::tasks.tests.integration.test_ghm_sync_plans
Stack Traces | 0s run time
ImportError while importing test module '.../tests/integration/test_ghm_sync_plans.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../local/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tasks/__init__.py:62: in <module>
    from tasks.upload import upload_task
tasks/__init__.py:62: in <module>
    from tasks.upload import upload_task
tasks/upload.py:21: in <module>
    from shared.upload.utils import UploaderType, bulk_insert_coverage_measurements
E   ImportError: cannot import name 'bulk_insert_coverage_measurements' from 'shared.upload.utils' (.../local/lib/python3.13.../shared/upload/utils.py)
tasks/tests/integration/test_status_set_pending_task.py::tasks.tests.integration.test_status_set_pending_task
Stack Traces | 0s run time
ImportError while importing test module '.../tests/integration/test_status_set_pending_task.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../local/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tasks/__init__.py:62: in <module>
    from tasks.upload import upload_task
tasks/__init__.py:62: in <module>
    from tasks.upload import upload_task
tasks/upload.py:21: in <module>
    from shared.upload.utils import UploaderType, bulk_insert_coverage_measurements
E   ImportError: cannot import name 'bulk_insert_coverage_measurements' from 'shared.upload.utils' (.../local/lib/python3.13.../shared/upload/utils.py)
tasks/tests/integration/test_timeseries_backfill.py::tasks.tests.integration.test_timeseries_backfill
Stack Traces | 0s run time
ImportError while importing test module '.../tests/integration/test_timeseries_backfill.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../local/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tasks/__init__.py:62: in <module>
    from tasks.upload import upload_task
tasks/__init__.py:62: in <module>
    from tasks.upload import upload_task
tasks/upload.py:21: in <module>
    from shared.upload.utils import UploaderType, bulk_insert_coverage_measurements
E   ImportError: cannot import name 'bulk_insert_coverage_measurements' from 'shared.upload.utils' (.../local/lib/python3.13.../shared/upload/utils.py)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

❌ 12 Tests Failed:

Tests completed Failed Passed Skipped
12 12 0 0
View the top 3 failed tests by shortest run time
tasks/tests/integration/test_ai_pr_review.py::::tasks.tests.integration.test_ai_pr_review
Stack Traces | 0s run time
No failure message available
tasks/tests/integration/test_sync_pull.py::::tasks.tests.integration.test_sync_pull
Stack Traces | 0s run time
No failure message available
tasks/tests/integration/test_upload_e2e.py::::tasks.tests.integration.test_upload_e2e
Stack Traces | 0s run time
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

github-actions bot commented Jan 8, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (5d72c6a) to head (2816ff6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files         446      446           
  Lines       36056    36056           
=======================================
  Hits        35322    35322           
  Misses        734      734           
Flag Coverage Δ
integration 42.04% <ø> (ø)
unit 90.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@giovanni-guidini giovanni-guidini force-pushed the gio/update-shared-I branch 2 times, most recently from 213ef26 to f31d526 Compare January 8, 2025 17:26
@giovanni-guidini giovanni-guidini requested a review from a team January 8, 2025 17:42
requirements.txt Outdated
# This file was autogenerated by uv via the following command:
# uv pip compile requirements.in -o requirements.txt
#
# This file is autogenerated by pip-compile with Python 3.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to compile this w/ uv don't we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, good catch 👍

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm aside from the pip-compile, lmk and I'll approve

Updates shared to codecov/shared#463
Which includes some changes to the tokens generated when we pull info for git providers.
Hence, we need some test changes to reflect the new info.
@giovanni-guidini giovanni-guidini added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 9fdd3e4 Jan 8, 2025
22 of 23 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/update-shared-I branch January 8, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants