Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

170 motion control add c++ encoder class #171

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mlecriva
Copy link
Contributor

Add encoder interface that provide method to reset and get traveled distance since last call.

Add encoder implementation for RIOT qdec driver.

@mlecriva mlecriva linked an issue Oct 10, 2024 that may be closed by this pull request
@mlecriva mlecriva force-pushed the 170-motion-control-add-c++-encoder-class branch from d9260cd to be4034d Compare October 10, 2024 19:31
Copy link
Contributor

@gdoffe gdoffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but I would make things simplier

lib/encoder/Makefile Show resolved Hide resolved
lib/encoder/include/EncoderParams.hpp Outdated Show resolved Hide resolved
lib/encoder/include/EncoderParams.hpp Outdated Show resolved Hide resolved
lib/encoder/include/EncoderParams.hpp Outdated Show resolved Hide resolved
lib/encoder/include/Encoder.hpp Outdated Show resolved Hide resolved
@mlecriva mlecriva force-pushed the 170-motion-control-add-c++-encoder-class branch 3 times, most recently from bd638bd to 01bd08f Compare October 23, 2024 08:49
@mlecriva mlecriva force-pushed the 170-motion-control-add-c++-encoder-class branch 5 times, most recently from 6f5648c to 10aeb31 Compare November 8, 2024 13:21
lib/encoder/include/encoder/EncoderInterface.hpp Outdated Show resolved Hide resolved
lib/encoder/include/encoder/EncoderQDEC.hpp Outdated Show resolved Hide resolved
Add encoder interface that provide method to reset and get
traveled distance since last call.

Add encoder implementation for RIOT qdec driver.

Signed-off-by: Mathis Lécrivain <[email protected]>
@mlecriva mlecriva force-pushed the 170-motion-control-add-c++-encoder-class branch from 10aeb31 to 33b4dd4 Compare November 8, 2024 19:09
@mlecriva mlecriva merged commit 92f42ef into master Nov 8, 2024
1 check passed
@mlecriva mlecriva deleted the 170-motion-control-add-c++-encoder-class branch November 13, 2024 10:41
@mlecriva mlecriva restored the 170-motion-control-add-c++-encoder-class branch November 13, 2024 11:13
@mlecriva mlecriva deleted the 170-motion-control-add-c++-encoder-class branch December 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motion control - Add C++ encoder class
3 participants