fix: cache result of "compute bounds of most geometry" to force deterministic results #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christjt
added
the
auto-update
|
📙 Documentation preview is available from |
christjt
changed the title
haakonflatval-cognite
approved these changes
Feb 23, 2022
Comment on lines
+74
to
+89
| getSectorsIntersectingFrustum( | ||
| projectionMatrix: THREE.Matrix4, | ||
| inverseCameraModelMatrix: THREE.Matrix4 | ||
| ): SectorMetadata[] { | ||
| const frustumMatrix = new THREE.Matrix4().multiplyMatrices(projectionMatrix, inverseCameraModelMatrix); | ||
| const frustum = new THREE.Frustum().setFromProjectionMatrix(frustumMatrix); | ||
| const accepted: SectorMetadata[] = []; | ||
| traverseDepthFirst(this.root, x => { | ||
| if (frustum.intersectsBox(x.subtreeBoundingBox)) { | ||
| accepted.push(x); | ||
| return true; | ||
| } | ||
| return false; | ||
| }); | ||
| return accepted; | ||
| } |
There was a problem hiding this comment.
Why is this moved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported by Aize where certain models would "bounce around" when clicking fit camera to model. Reason for this is that
skmeans, which we use to compute the bounding box of the model without noise, is not deterministic. The rubberband fix for this (since sadly it doesn't support seed solzimer/skmeans#18) is to only compute once and cache the result.