Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track code coverage using codecov #158

Merged
merged 2 commits into from
May 29, 2024
Merged

Track code coverage using codecov #158

merged 2 commits into from
May 29, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented May 29, 2024

No description provided.

@cottsay cottsay requested a review from nuclearsandwich May 29, 2024 18:30
@cottsay cottsay self-assigned this May 29, 2024
Copy link

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why the indentation is not the same as colcon/colcon-core#648?

@cottsay
Copy link
Member Author

cottsay commented May 29, 2024

Any reason why the indentation is not the same ... ?

Oh wow, that's a bug.

@cottsay
Copy link
Member Author

cottsay commented May 29, 2024

Fixed in 8da2e89. I'm glad one of us is paying attention!

@cottsay
Copy link
Member Author

cottsay commented May 29, 2024

Aside: It's frustrating that introducing a problem in the GitHub actions doesn't result in any indication of failure in the PR. The actions simply don't run.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: It's frustrating that introducing a problem in the GitHub actions doesn't result in any indication of failure in the PR. The actions simply don't run.

Definitely.

@cottsay cottsay merged commit c5452db into master May 29, 2024
17 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/codecov branch May 29, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants