Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for python 3.12 #113

Merged
merged 2 commits into from
Apr 22, 2024
Merged

add support for python 3.12 #113

merged 2 commits into from
Apr 22, 2024

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Apr 5, 2024

No description provided.

@pbauer pbauer requested a review from mauritsvanrees April 5, 2024 10:18
@pbauer pbauer requested a review from davisagli April 5, 2024 11:35
@pbauer
Copy link
Member Author

pbauer commented Apr 5, 2024 •
edited
Loading

I think Plone never used pygettext.py except for some helpers from it. Using the script directly was broken starting from version 5.0.0 in 2018. In Version 4.3 on Python 2.7 the result is basically the same as now with this pull-request. We could also simply remove everything we don't use...

mauritsvanrees
mauritsvanrees approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mauritsvanrees mauritsvanrees merged commit 15e2056 into master Apr 22, 2024
6 checks passed
@mauritsvanrees mauritsvanrees deleted the python312 branch April 22, 2024 09:46
@mauritsvanrees
Copy link
Member

I have released i18ndude 6.2.0 and have updated coredev 6.0 and 6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbauer @mauritsvanrees