Add Rails 7.2 support (#484)

This change adds Rails 7.2 support and updates our CI configuration to test it. --------- Co-authored-by: Philip Arndt <[email protected]>
collectiveidea · Aug 28, 2024 · 11f3cac · 11f3cac
1 parent cb672d9
commit 11f3cac
Show file tree

Hide file tree

Showing 7 changed files with 60 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,6 +13,7 @@ jobs:
   sqlite:
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
         gemfile:
@@ -21,6 +22,7 @@ jobs:
           - rails_6_1
           - rails_7_0
           - rails_7_1
+          - rails_7_2
           - rails_main
         exclude:
           - ruby: '3.2'
@@ -35,7 +37,7 @@ jobs:
           - ruby: '3.0'
             gemfile: rails_5_2
 
-          # Rails 8 requires Ruby 3.1 or higher
+          # Rails 7.2 requires Ruby 3.1 or higher
           - ruby: '2.6'
             gemfile: rails_main
 
@@ -50,6 +52,15 @@ jobs:
 
           - ruby: '2.6'
             gemfile: rails_7_1
+
+          - ruby: '2.6'
+            gemfile: rails_7_2
+
+          - ruby: '2.7'
+            gemfile: rails_7_2
+
+          - ruby: '3.0'
+            gemfile: rails_7_2
     env:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
       BUNDLE_PATH_RELATIVE_TO_CWD: true
@@ -73,6 +84,7 @@ jobs:
   mysql:
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         ruby: ['2.6', '2.7', '3.0', '3.1']
         gemfile:
@@ -81,6 +93,7 @@ jobs:
           - rails_6_1
           - rails_7_0
           - rails_7_1
+          - rails_7_2
           - rails_main
         exclude:
           - ruby: '3.2'
@@ -110,6 +123,15 @@ jobs:
 
           - ruby: '2.6'
             gemfile: rails_7_1
+
+          - ruby: '2.6'
+            gemfile: rails_7_2
+
+          - ruby: '2.7'
+            gemfile: rails_7_2
+
+          - ruby: '3.0'
+            gemfile: rails_7_2
     env:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
       BUNDLE_PATH_RELATIVE_TO_CWD: true
@@ -148,6 +170,7 @@ jobs:
   postgres:
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
         gemfile:
@@ -156,6 +179,7 @@ jobs:
           - rails_6_1
           - rails_7_0
           - rails_7_1
+          - rails_7_2
           - rails_main
         exclude:
           - ruby: '3.2'
@@ -185,6 +209,15 @@ jobs:
 
           - ruby: '2.6'
             gemfile: rails_7_1
+
+          - ruby: '2.6'
+            gemfile: rails_7_2
+
+          - ruby: '2.7'
+            gemfile: rails_7_2
+
+          - ruby: '3.0'
+            gemfile: rails_7_2
     env:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
       BUNDLE_PATH_RELATIVE_TO_CWD: true

diff --git a/Appraisals b/Appraisals
@@ -1,4 +1,11 @@
-{ '5_2' => '5.2.0', '6_0' => '6.0.0', '6_1' => '6.1.0', '7_0' => '7.0.0', '7_1' => '7.1.0' }.each do |rails, version|
+{
+  "5_2" => "5.2.0",
+  "6_0" => "6.0.0",
+  "6_1" => "6.1.0",
+  "7_0" => "7.0.0",
+  "7_1" => "7.1.0",
+  "7_2" => "7.2.0"
+}.each do |rails, version|
   appraise "rails-#{rails}" do
     gem "rails", "~> #{version}"
   end

diff --git a/awesome_nested_set.gemspec b/awesome_nested_set.gemspec
@@ -18,12 +18,12 @@ Gem::Specification.new do |s|
 
   s.required_ruby_version = '>= 2.0.0'
 
-  s.add_runtime_dependency 'activerecord', '>= 4.0.0', '< 7.2'
+  s.add_runtime_dependency 'activerecord', '>= 4.0.0', '< 8.0'
 
   s.add_development_dependency 'appraisal'
   s.add_development_dependency 'database_cleaner'
   s.add_development_dependency 'pry'
   s.add_development_dependency 'pry-nav'
   s.add_development_dependency 'rake', '~> 13'
-  s.add_development_dependency 'rspec-rails', '~> 4.0.0'
+  s.add_development_dependency 'rspec-rails', '>= 4.0.0', '<= 6.2'
 end
diff --git a/gemfiles/rails_6_0.gemfile b/gemfiles/rails_6_0.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "rails", "~> 6.0.0"
 
 platforms :ruby do
-  gem "sqlite3"
+  gem "sqlite3", "~> 1.4"
   gem "mysql2", "< 1.0.0"
   gem "pg", "< 2.0.0"
 end

diff --git a/gemfiles/rails_6_1.gemfile b/gemfiles/rails_6_1.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "rails", "~> 6.1.0"
 
 platforms :ruby do
-  gem "sqlite3"
+  gem "sqlite3", "~> 1.4"
   gem "mysql2", "< 1.0.0"
   gem "pg", "< 2.0.0"
 end

diff --git a/gemfiles/rails_7_0.gemfile b/gemfiles/rails_7_0.gemfile
@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "rails", "~> 7.0.0"
 
 platforms :ruby do
-  gem "sqlite3"
+  gem "sqlite3", "~> 1.4"
   gem "mysql2", "< 1.0.0"
   gem "pg", "< 2.0.0"
 end

diff --git a/gemfiles/rails_7_2.gemfile b/gemfiles/rails_7_2.gemfile
@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 7.2.0"
+
+platforms :ruby do
+  gem "mysql2", "< 1.0.0"
+  gem "pg", "< 2.0.0"
+  gem "sqlite3"
+end
+
+gemspec path: "../"