Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fingerprints.py for 2024 Hyundai Tucson #1601

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Curtrahmel
Copy link

Added " b'\xf1\x00NX4 FR_CMR AT USA LHD 1.00 1.00 99211-CW020 14Z', "
--> to " CAR.TUCSON_4TH_GEN: {
(Ecu.fwdCamera, 0x7c4, None): [ "

<!--- ***** Template: Fingerprint *****

**Car**
2024 Hyundai Tucson

**Route**
662d2739183135b3|2024-01-13--06-07-06

-->

Added " b'\xf1\x00NX4 FR_CMR AT USA LHD 1.00 1.00 99211-CW020 14Z', "
   --> to " CAR.TUCSON_4TH_GEN: {
    (Ecu.fwdCamera, 0x7c4, None): [ "
@github-actions github-actions bot added car related to opendbc/car/ hyundai fingerprint labels Dec 24, 2024
@staeiou
Copy link

staeiou commented Jan 9, 2025

This is also my fingerprint. Is there something blocking this PR that I can help with?

@Curtrahmel
Copy link
Author

I don't know what is blocking it, but before they switched the location of the fingerprint file, it was easy to make the changes to it so I could take advantage of the improvements. Now, due to inexperience, I am not able to use my device on the latest os. Any help would be greatly appreciated.

@staeiou
Copy link

staeiou commented Jan 10, 2025

Looking into it more. This seems to be failing because there is a blacklist against the "CW" part of the fingerprint. There is a comment: " # Asserts no ECUs known to be shared across platforms exist in the database.
# Tucson having Santa Cruz camera and EPS for example"

def test_blacklisted_parts(self, subtests):

@Curtrahmel
Copy link
Author

Is there anything that can be done to fix it? I have used that for over 19000 miles with no major issues.

@staeiou
Copy link

staeiou commented Jan 10, 2025

The PR that added the blacklist is commaai/openpilot#28318

@sshane @sunnyhaibin it looks like you were involved in this, can you help us out? There are two of us that have 2024 Tucsons with a fingerprint that has the "CW" in the blacklist.

Route: 6d9d843a1b27bc98|00000003--6558424d55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ fingerprint hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants