Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Remaining Generated Function Problems #439

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

willtebbutt
Copy link
Member

There remain a few generated functions which use functionality which they ought not to. This PR will resolve this.

Follows on from #426

There are a few more generated functions which require attention, but I want to get this PR open to get CI running asap to verify that I've not broken stuff more widely.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/fwds_rvs_data.jl 95.94% <100.00%> (-0.73%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │     85.5 │     1.1 │        5.61 │    8.21 │
│                  _sum_1000 │     6.69 │  1320.0 │        33.7 │    1.08 │
│               sum_sin_1000 │     2.29 │    1.68 │        10.7 │    1.97 │
│              _sum_sin_1000 │     2.62 │   258.0 │        13.4 │    2.41 │
│                   kron_sum │     61.6 │    3.62 │       274.0 │    8.73 │
│              kron_view_sum │     21.4 │    3.36 │        81.2 │    35.1 │
│      naive_map_sin_cos_exp │     2.62 │ missing │        7.19 │    2.34 │
│            map_sin_cos_exp │     2.83 │    1.44 │        6.11 │    2.94 │
│      broadcast_sin_cos_exp │     2.63 │    2.25 │        1.45 │    2.26 │
│                 simple_mlp │     4.94 │    3.09 │        7.24 │    3.48 │
│                     gp_lml │     4.51 │    2.26 │     missing │    2.89 │
│ turing_broadcast_benchmark │     3.18 │ missing │        30.0 │ missing │
│         large_single_block │     4.42 │  3960.0 │        30.5 │    2.18 │
└────────────────────────────┴──────────┴─────────┴─────────────┴─────────┘

@willtebbutt willtebbutt merged commit 4e4fd28 into main Jan 8, 2025
8 of 9 checks passed
@willtebbutt willtebbutt deleted the wct/fix-more-generated-functions branch January 8, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant