Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned requirements with upstream 2.6.1 #18

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

timostrunk
Copy link
Contributor

@timostrunk timostrunk commented Feb 28, 2024

Upstream pyproject.toml changed a lot:
https://github.com/rthalley/dnspython/blob/main/pyproject.toml
As far as I understand nothing is required anymore. I kept the sniffio dependency, because I don't want to break current users and sniffio is used in the asyncio check.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@timostrunk
Copy link
Contributor Author

@conda-forge-admin, please rerender

@synapticarbors
Copy link
Member

@timostrunk -- good catch. I guess the grayskull update doesn't catch run_constrained requirements? I think this looks good, but will wait for the other co-maintainers to chime in before merging.

@xylar
Copy link
Contributor

xylar commented Feb 28, 2024

I think we should remote bot automerge to prevent this kind of thing happening.

@xylar
Copy link
Contributor

xylar commented Feb 28, 2024

@xylar
Copy link
Contributor

xylar commented Feb 28, 2024

My guess is that the grayskull bot update failed because grayskull is still struggling with certain pyproject.toml syntax (lists of dependencies with different constraints conda/grayskull#463).

@synapticarbors
Copy link
Member

@timostrunk -- would you remove the automerge from the config shown in #18 (comment)? Then I think we should be good to merge this PR.

@timostrunk
Copy link
Contributor Author

Will do

@timostrunk
Copy link
Contributor Author

@conda-forge-admin, please rerender

@@ -1,6 +1,6 @@
conda_forge_output_validation: true
bot:
automerge: true
automerge: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automerge is removed and I rerendered afterwards

@xylar
Copy link
Contributor

xylar commented Feb 29, 2024

Thanks @timostrunk!

@xylar xylar merged commit 28f96a4 into conda-forge:main Feb 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants