Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debian-based builder image for bulding Linux glibc images #228

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Jan 3, 2025

Since the official node:{version} docker images are built on debian images, it makes sense to stick to those. This also helps ensure compatibility as the agent glibc versions may change, but using a docker image to build it keeps things as we expect.

Later on, when bullseye goes EOL, we can transition those builds to bookworm as well (and so on and so forth to the next versions). We get Ubuntu LTS builds ensured to be correct if we build on Debian, and I'm also adding some post-install tests to make sure that we can build successfully on the listed targets too.

Note that node v23 isn't supported in bullseye -- we never supported it as the agents were already 22.04 when we started supporting it. I've documented it in the README.

Successful build using this change: https://semaphore.ci.confluent.io/workflows/9c1a32e0-2e99-4f33-814f-8469dba04760?pipeline_id=26681b55-8aad-4564-9b3a-ecb1334a8389 (some flaky failure of promisified tests). I will remove the "Change version for testing" commit after review.

Fixes #221

@milindl milindl requested review from a team as code owners January 3, 2025 05:17
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@airlock-confluentinc airlock-confluentinc bot force-pushed the fix_glibc_version_node18 branch from f9f18b9 to 4ed51e3 Compare January 10, 2025 06:45
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (70.20% Estimated after merge)
  • Duplications No duplication information (3.60% Estimated after merge)

Project ID: confluent-kafka-javascript

View in SonarQube

@milindl
Copy link
Contributor Author

milindl commented Jan 10, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found
1 participant