Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#538 - LOG_DIR not set causing FileNotFoundException #688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#538 - LOG_DIR not set causing FileNotFoundException #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bin/kafka-rest-run-class
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ if [ "x$KAFKAREST_LOG4J_OPTS" = "x" ]; then
fi
fi

# Log directory to use
if [ "x$LOG_DIR" = "x" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[ -z "${LOG_DIR+x}" ]] && LOG_DIR="$base_dir/logs"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, not sure if $base_dir/logs is a better default log folder than, for example, /var/log/kafka-rest. AK uses /var/log/kafka by default, I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @rigelbm -- I used the same $base_dir/logs default folder code present in both AK and CP kafka-run-class files, so that things remained consistent. I can change the logic to your modified version though if you prefer?

LOG_DIR="$base_dir/logs"
fi

if [[ -n $LOG_DIR ]]; then
[[ -d $LOG_DIR ]] || mkdir -p "$LOG_DIR"
KAFKAREST_LOG4J_OPTS="-Dkafka-rest.log.dir=$LOG_DIR ${KAFKAREST_LOG4J_OPTS}"
Expand Down