Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feat: Cloning #4777

Draft
wants to merge 16 commits into
base: next
Choose a base branch
from
Draft

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Jan 8, 2025

Changes

  • feat: Docker volume data can optionally be cloned alongside the resource (so it is a true full clone of the resource, everything is exactly the same (except the name ofc)).
  • fix: Undefined variable $fs_path error on file mounts for databases
  • chore: switched up read-only labels checkbox to make more sense -> Read-only labels are now the default and mean that they are read-only (not editable) and Coolify will autogenerate the labels, if you uncheck read-only you can edit them and Coolify will not autogenerate any labels.
  • fix: remove auto-generated properties (id, created_at and updated_at ) from replicate as that caused issues
  • fix: exclude computed count properties (additional_servers_count, additional_networks_count) loaded by global scope to prevent errors
  • fix: cloning a service to a separate server. To be able to clone a service to a new server we need to set the server_id to the DB as well, otherwise it will be cloned on the same server.
  • fix: volume naming after cloning
  • fix: project/ environment level cloning and also fixed resource level cloning (same fixes described below for both)
  • fix: Application cloning:
    • fix: disable auto-generated of URLs and labels if read-only labels is false.
    • fix: labels where not auto-generated for CloneMe (project / environment level cloning) if read-only labels is true, now they are generated again
    • fix: some settings get lost when cloning Applications because we need to clone the row in the application_settings table as well
    • fix: clone file and directory mounts
    • fix: clone tags
    • fix: clone scheduled tasks
    • fix: clone preview deployment settings
  • fix: Databases cloning:
    • fix: clone tags
    • fix: clone volumes
    • fix: clone file and directory mounts
    • fix: clone backup schedules
  • fix: Services cloning:
    • fix: clone environment variables
    • fix: clone tags
    • fix: clone scheduled task
    • fix: clone volumes
    • fix: clone file and directory mounts
    • fix: clone backup schedules for service databases

Issues

/claim #4725

- Remove auto-generated properties (`id`, `created_at` and `updated_at` ) from replicate
- Exclude computed count properties (`additional_servers_count`, `additional_networks_count`) loaded by global scope to prevent errors
- To be able to clone a service to a new server we need to set the server_id as well, otherwise it will be cloned on the same server.
- disable URL auto generation
- clone Application settings as well
- clone tags
- clone scheduled tasks
- clone preview deployment settings
- clone file and directory mounts
Databases:
- clone tags
- clone volumes
- clone file and directory mounts
- clone backup schedules

Services:
- clone tags
- clone scheduled task
- clone environment variables
- UI implementation
- functional implementation for databases - volume gets cloned successfully
- fix: volume naming
- fix: clone file and directory mounts for services
- fix: clone volumes for services
- fix: clone scheduled tasks for service applications
- fix: clone backup schedules for service databases
- feat: clone Volume data for services and applications
@peaklabs-dev peaklabs-dev changed the title Fix: Cloning fix/feat: Cloning Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant