-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/feat: Cloning #4777
Draft
peaklabs-dev
wants to merge
16
commits into
coollabsio:next
Choose a base branch
from
peaklabs-dev:fix-cloning
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix/feat: Cloning #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove auto-generated properties (`id`, `created_at` and `updated_at` ) from replicate - Exclude computed count properties (`additional_servers_count`, `additional_networks_count`) loaded by global scope to prevent errors
- To be able to clone a service to a new server we need to set the server_id as well, otherwise it will be cloned on the same server.
- disable URL auto generation - clone Application settings as well - clone tags - clone scheduled tasks - clone preview deployment settings - clone file and directory mounts
Databases: - clone tags - clone volumes - clone file and directory mounts - clone backup schedules Services: - clone tags - clone scheduled task - clone environment variables
- UI implementation - functional implementation for databases - volume gets cloned successfully
- fix: volume naming - fix: clone file and directory mounts for services - fix: clone volumes for services - fix: clone scheduled tasks for service applications - fix: clone backup schedules for service databases - feat: clone Volume data for services and applications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Undefined variable $fs_path
error on file mounts for databasesid
,created_at
andupdated_at
) from replicate as that caused issuesadditional_servers_count
,additional_networks_count
) loaded by global scope to prevent errorsserver_id
to the DB as well, otherwise it will be cloned on the same server.false
.true
, now they are generated againapplication_settings
table as wellIssues
/claim #4725