Fix aws metrics cloudformation texts (#167)

coralogix · Nov 27, 2024 · 1816f33 · 1816f33
1 parent 79d10f5
commit 1816f33
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/coralogix-policies/coralogix-metrics-integration-policy/CHANGELOG.md b/coralogix-policies/coralogix-metrics-integration-policy/CHANGELOG.md
@@ -48,3 +48,6 @@
 ### 11.4.2024
 ### 🚀 New components 🚀
 - Create metrics integration module
+
+### 27.11.2024
+### Fix CustomAccountId field name for custom account and align template description
diff --git a/coralogix-policies/coralogix-metrics-integration-policy/README.md b/coralogix-policies/coralogix-metrics-integration-policy/README.md
@@ -8,7 +8,7 @@ The module will create a role to be used with AwsMetrics integration
 |-----------|-------------|---------------|----------|
 | AWSAccount | The Alias for the Coralogix region, possible options are [US1, US2, EU1, EU2, AP1, AP2, AP3, dev, staging, custom] | EU1 | :heavy_check_mark: |
 | RoleName | The name of the rule that template will create in your AWS account | n\a | :heavy_check_mark: |
-| CustomerAccountId | In case you want to use a custom coralogix account, enter the aws account id that you want to use.| n\a  | |
+| CustomAccountId | In case you want to use a custom coralogix account, enter the aws account id that you want to use.| n\a  | |
 | ExternalId | "sts:ExternalId" this id is used for increased security | n\a | :heavy_check_mark: |
 
 Run the following command to deploy the integration:

diff --git a/coralogix-policies/coralogix-metrics-integration-policy/template.yaml b/coralogix-policies/coralogix-metrics-integration-policy/template.yaml
@@ -1,5 +1,5 @@
 AWSTemplateFormatVersion: 2010-09-09
-Description: The module will create a role with an inline policy to allow Coralogix to send events to an EventBridge event bus.
+Description: The module will create a role with an inline policy to allow Coralogix to collect metrics from several resource types.
 Parameters:
   ExternalId:
     Description: "ExternalId for sts:AssumeRole"
@@ -22,9 +22,9 @@ Parameters:
   RoleName:
     Type: String
     Description: The name of the role that will be created.
-  CustomerAccountId:
+  CustomAccountId:
     Type: String
-    Description: Custom AWS account ID that you want to deploy the integration in.
+    Description: Custom AWS account ID that you want to deploy the integration in (overrides aws account id from CoralogixEnvironment variable).
     Default: ""
 
 Mappings:
@@ -60,7 +60,7 @@ Mappings:
       ID: 000000000000
       RoleSuffix: custom
 Conditions:
-  IsCustomAccountId: !Not [!Equals [!Ref CustomerAccountId, ""]]
+  IsCustomAccountId: !Not [!Equals [!Ref CustomAccountId, ""]]
 Resources:
   CoralogixAwsMetricsRole:
     Type: AWS::IAM::Role
@@ -76,7 +76,7 @@ Resources:
                 - "arn:aws:iam::${aws_account_id}:role/coralogix-ingestion-${role_suffix}"
                 - aws_account_id: !If
                     - IsCustomAccountId
-                    - !Ref CustomerAccountId
+                    - !Ref CustomAccountId
                     - !FindInMap [CoralogixEnvironment, !Ref AWSAccount, "ID"]
                   role_suffix: !FindInMap [CoralogixEnvironment, !Ref AWSAccount, "RoleSuffix"]
             Action: