Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mount ecs ec2 #122

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix mount ecs ec2 #122

merged 2 commits into from
Mar 13, 2024

Conversation

daidokoro
Copy link
Collaborator

@daidokoro daidokoro commented Mar 13, 2024

  • Example of receiving the S3 payload

  • newline_pattern

  • sending to coralogix

  • sending as batch

  • Put records in ExportLogsServiceRequest

  • sent to coralogix working

  • added gzip at source

  • Limit batch size to 500 logs

  • Adding integration_type

  • Implement splitting with fancy regexes

  • WIP Blocking Pattern

  • Blocking Working

  • wip sampling blocking_pattern

  • WIP DynamicAppName

  • WIP dyn app

  • Dynamic application/subsystem name

  • added cloudtrail support WIP

  • Cloudwatch working

  • WIP Severity

  • Severity fix

  • Severity Matcher

  • Resource per app/subsystem

  • git ignored cargo.lock

  • cloudtrail working

  • initial sns

  • sns working

  • Working SNS

  • Split initial

  • Split initial

  • vpcflow working

  • Cloudwatch work in progress

  • Cloudwatch work in progress

  • Refactor/split code

  • initial template

  • added sam makefile

  • added workfllows

  • updated triggers

  • adjust workflow

  • added requirements txt

  • add ssh agent

  • add proto

  • add sudo

  • change lambda name

  • change name

  • add license

  • updated Author

  • added version change check

  • fix exit

  • added job depenedencies

  • adjust push

  • [skip-version-check]

CoralogixRegionMap the log URL should actually be the domain and than we need to build CORALOGIX_URL from it with prefix/sufix the reason for it are 2 like in here
we wanted just one place to change if the URL changes (the domain is not)
the support of CustomDomain that i see currently missing from the setting
the URL should be https://ingress.coralogix.com:443 so currently prefix is https://ingress domain is coralogix.com sufix :443` (not sure if sufix is needed or can stay empty for now
CoralogixRegion should custom option and this should be the default setting unless someone select otherwise something similar to what we did for firehose
PrivateKey should be changed to ApiKey
not sure that we have MaxLength for application or subsystem names (i know we have it now but not sure we have limit on our backend)
we need to add ParameterGroups in the template (like we discuss so the template will be more readable) we also have it in some of the current templates
not sure about the labels list (i think we should remove athena,query,results)
Description i think should be Send logs to Coralogix from AWS since we will have also cloudwatch
not sure that we need BufferSize i dont think we have any
what about FunctionArchitecture we should give option to run on x86_64 or arm64 (default should be arm64)
the lambda description should be generic not like now
CustomResourceLambdaTriggerFunction should be only in case it is S3, we need to add some condition so when we will have cloudwatch this will not be trigger so need to think how to create it and also support the cloudwatch parmas i think it is only CloudWatchLogGroupName
for S3KeyPrefix/S3KeySuffix how do we set them per the use case? i.e in cloudtrail they should be set by default
missing SNSTopicArn param so if customer want to use his topic he should add the ARN and we need to register to this topic
missing SamplingRate
missing BlockingPattern
missing NewlinePattern which is different syntax than what we currently have like juan explained
why the python runtime for the CustomResourceLambdaTriggerFunction is 3.9 and not latest 3.11
we need probably a new param IntegrationType so they can set
S3/Cloudtarail/Cloudwatch/VPC-Flow/etc...

  • [skip-version-check] fix variable declaration

  • [skip-version-check] removed AWS::LanguageExtension transform

  • [skip-version-check] fix dependson

  • [skip-version-check] fix code uri

  • template updated

  • adjust template

  • Cloudwatch working

  • thread_id WIP

  • [skip-version-check] fixed UseSNSTopicARM condition and updated function
    variables

  • gitignore

  • Add thread_id to log_record

  • [skip-version-check] Added metadata for grouping parameters. Set the
    Newline Param to empty by default. Set the S3KeyPrefix var to empty by
    default.

  • [skip-version-check] update lambdafunction key name in store workflow

  • update sync workflow

  • change workflow name

  • add -f flag

  • add signing -S

  • [skip-version-check] updated suffix

  • updated s3 suffix

  • [skip-version-check] updated

  • Send batches in parallel

  • [skip-version-check] added rule assertion for parameter validation, updated metadata label grouping

  • LogMode::Vanilla

  • [skip-version-check]

  • merge fix

  • [skip-version-check] update descriptions

  • [skip-version-check] update retention description

  • WOIP

  • Cloudwatch fix

  • CW Fix

  • fix errors in main

  • fix

  • Fix Cargo.lock

  • dependency update

  • add get_api_key_from_secrets_manager

  • adjust main function to support fetching secret

  • [skip-version-check] added SecretStore variable and fixed Assertion

  • added planetscale workflow

  • updated

  • adjust repo

  • added content write

  • add sync call

  • updated repo name

  • dependencies

  • fix api key

  • [skip-version-check]

Fixed cloudwatchgroupname parameter
Fixed cloudwatch custom resource function parameters
Removed S3 trigger for SNS topic deployment
Added Stackid to Secret creation name

  • addded custom sync

  • remove separate sync workflow

  • fix merge conflicts

  • re-add sync workflow

  • remove sync step


Co-authored-by: juan-coralogix [email protected]
Co-authored-by: Rafał Sumisławski [email protected]
Co-authored-by: juan-coralogix [email protected]

Signed-off-by: guyrenny [email protected]

  • update the tempalte.yaml to incloud custom in region mapping

Signed-off-by: guyrenny [email protected]


Signed-off-by: guyrenny [email protected]

unwrap remove

Co-authored-by: Rafał Sumisławski [email protected]

  • Update src/process.rs

Co-authored-by: Rafał Sumisławski [email protected]

  • Fix clone issue

Co-authored-by: Rafał Sumisławski [email protected]


Co-authored-by: juan-coralogix [email protected]
Co-authored-by: Rafał Sumisławski [email protected]
Co-authored-by: juan-coralogix [email protected]

  • Update README.md

  • Update README.md

  • Update template.yaml
  • [skip-version-check] CDS-719 add csvdelimiter variable (Ecs fargate support #35) * [skip-version-check] add csvdelimiter variable

  • [cds-724] Update cloudformation template ([cds-305] Update ECS-EC2 cloudformation template #34) * [skip-version-check]

  • s3 bucket name should not be mandatory need to update the regex probebly to validate it is minimum 3 latters

  • Add note for prefix/sufix that it is not working with sns and add condition to validate it is empty when sns is used so it will not confuse customers

  • change serverless function name to coralogix-aws-shipper

  • S3KeySuffix for VPC flowlog default suffix set to .json.gz and default Prefix set to AWSLogs

  • removed LogsPerBatch param

  • added note to description saying this a beta release

  • [skip-version-check] added badge for publish workflow

  • [skip-version-check] adjust branch location

  • [skip-version-check] updated s3 param

  • [skip-version-check] adjust discription for s3bucket

  • [skip-version-check] fix license badge

  • [skip-version-check]removed default prefix for s3 integration

  • [skip-version-check] adjust cargo version to match template

  • [skip-version-check] add badged

  • [skip-version-check] updated cloudwatch filter name

  • [skip-version-check] re-add event on failure to cloudwatch lambda

  • [skip-version-check] change badge name

  • Update template syntax

  • [cds-724] Update template syntax

  • Adjust readme and CF/SAM template

  • Fixed version validation

  • Update template.yaml

  • Update CHANGELOG.md

  • Update README.md

  • Update config.rs

Added Sns support

  • Filter the list of lambda functions which should be the subject of metadata collection#feature/NGSTN-464-metadata-lambda-filtering
  • Feature/ngstn 464 fix readme table#feature/NGSTN-464-fix-readme-table
  • [skip-version-check]change the prefix and suffix to the vpcflow[CDS-719] (added cf text change to trigger #64) * change the prefix and suffix to the vpcflow
  • skip cahngelog
  • added csv empty line fix
  • [cds-719][skip-version-check] Readme update (Test pr branch #69) * Readme update
  • [skip-version-check][cds-719] Hide newline and blocking pattern values if not set (Test pr branch #70) * [skip-version-check] added default empty string for NEWLINE_PATTERN and BLOCKING_PATTERN
  • [skip-version-check] NEWLINE and BLOCKING pattern env vars made to not show if not set

  • Update template.yaml

  • Update CHANGELOG.md


Co-authored-by: royfur [email protected]

  • removed test file

  • align cargo.toml version with template version

  • changelog


Co-authored-by: Concourse [email protected]

  • add key on gz error

  • changelog

  • Update CHANGELOG.md

  • variable set

  • changlog update

  • changed default logging level

  • Added Rust Report Card

  • Update version to 0.0.2

  • Fix default LogLevel

  • added file size in s3 logging

  • align cargo.toml version with template version


Co-authored-by: royfur [email protected]
Co-authored-by: Concourse [email protected]

  • changelog
  • moved internal logic to lib.rs

  • initial commit for integration tests

  • removed unused imports

  • added comments to test macro

  • udpate s3 event

  • changelog

  • changelog

  • add bad code

  • bad code

  • updated dependencies

  • refactored integration tests

  • Added mock s3 client and removed the need to call aws apis. Add local
    test files, refactored tests

  • added formatting

  • dependencies

  • moved s3 key decoding into s3 handler function directly

  • moved s3 key decoding

  • added test_s3_event_handler

  • move test_handle_s3_event to unit test

  • add tests workflow

  • add tag step

  • align cargo.toml version with template version

  • align changelog with version


Co-authored-by: Concourse [email protected]

  • align cargo.toml version with template version

Co-authored-by: Concourse [email protected]

  • align cargo.toml version with template version

  • Update CHANGELOG.md

  • Update Cargo.toml version

  • align cargo.toml version with template version


Co-authored-by: Concourse [email protected]


Co-authored-by: Concourse [email protected]

  • change version
  • initial test add

  • removed metadata label for s3csv

  • add elb gz log

  • update loglevel

  • Update README.md

  • Update CHANGELOG.md

  • Update version

  • align cargo.toml version with template version

  • Update README.md

  • Update README.md

  • Update template.yaml


Co-authored-by: Concourse [email protected]

  • Update sync.yml to private messages
  • simplify comebined event serialization

  • added kafka_logs process fn

  • added kafka test

  • template initial commit

  • added MSK integration type

  • changelog

  • added kafka integration type test

  • added integration tests for base64

  • added support for msk and kafka to cfn template

  • updated README with kafka and msk details

  • added option to parse base64 kafka values

  • added kafka integration type

  • added base64 parsing to dependencies

  • mdox formatting

  • Update src/process.rs

Co-authored-by: Roman Timushev [email protected]

  • add parameter group for kafka and msk

  • added MSK and Kafka to list of support services, merged kafka and msk configiruation sections

  • update dependencies


Co-authored-by: Roman Timushev [email protected]

  • align cargo.toml version with template version

  • adjust condition

  • removed validation from comaseparated list parameters


Co-authored-by: Concourse [email protected]

  • adjusted all tests to ensure that they call the deserializer, removed internal reverence to underlying types.

  • change log

  • adjust comments

  • Add default to subsystem param

  • Updated version

  • align cargo.toml version with template version


Co-authored-by: royfur [email protected]
Co-authored-by: Concourse [email protected]


Co-authored-by: Rafał Sumisławski [email protected]
Co-authored-by: royfur [email protected]

  • Update template.yaml

  • align cargo.toml version with template version


Co-authored-by: Concourse [email protected]

Description

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's readme or docs change)

@daidokoro daidokoro requested a review from a team as a code owner March 13, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants