Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify grpc as appprotocol in cfn exmaple, needed to properly export traces #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

specify grpc as appprotocol in cfn exmaple, needed to properly export traces #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db86323
specify grpc as appprotocol in cfn exmaple, needed to properly export…
Oct 25, 2024
a828f1c
update changelog
Oct 25, 2024
0b91334
4318 should be http
Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions aws-integrations/ecs-fargate/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
<!-- ### version / full date -->
<!-- * [Update/Bug fix] message that describes the changes that you apply -->

### 0.0.7 / 2024-10-25
* [CHANGE] Specify grpc as appProtocol, needed to properly export traces.

### 0.0.6 / 2024-10-18
* [UPDATE] Update ecs-fargate integration cf to allow larger "Advanced" Parameter Store.
* [UPDATE] Adjust roles to true minimum requirements.
Expand Down
4 changes: 3 additions & 1 deletion aws-integrations/ecs-fargate/ecs-fargate-cf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,11 @@ Resources:
- ContainerPort: 4317
HostPort: 4317
Protocol: tcp
AppProtocol: grpc
- ContainerPort: 4318
HostPort: 4318
Protocol: tcp
AppProtocol: http
Essential: false
Command: ["--config", "env:SSM_CONFIG"]
Environment:
Expand Down Expand Up @@ -285,4 +287,4 @@ Resources:
Resource: !Sub
arn:aws:ssm:${AWS::Region}:${AWS::AccountId}:parameter/${OTELConfigParameter}
Roles:
- !Ref ECSExecutionRole
- !Ref ECSExecutionRole