Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cds 756 Add DLQ Support #85

Merged
merged 19 commits into from
Apr 18, 2024
Merged

Cds 756 Add DLQ Support #85

merged 19 commits into from
Apr 18, 2024

Conversation

daidokoro
Copy link
Contributor

@daidokoro daidokoro commented Apr 15, 2024

Description

coralogix-aws-shipper_gh_workflow

This PR adds support for enabling a DLQ for the coralogix-aws-shipper lambda function.

  • Updated the main code base to support the new dlq workflow
  • Updated how aws clients are handled by the lambda
  • Updated all integration tests and added new ones for DLQ
  • Update cloudformation template to support DLQ parameters
Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the versions in the SemanticVersion in template.yaml
  • I have updated the CHANGELOG.md
  • I have created necessary PR to Terraform Module Repository (https://github.com/coralogix/terraform-coralogix-aws) if needed
  • This change does not affect any particular component (e.g. it's CI or docs change)

@daidokoro daidokoro requested a review from a team as a code owner April 15, 2024 14:27
Copy link
Collaborator

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daidokoro daidokoro merged commit b5de1b3 into dev Apr 18, 2024
8 checks passed
@daidokoro daidokoro deleted the cds-756 branch April 18, 2024 14:56
daidokoro added a commit that referenced this pull request Apr 23, 2024
* cargo

* Feature/ecr tests (#63)

ECR Tests added

* add env variable to control architecture selection in Makefile

* added x86_64 build path to publish workflows

* added CpuArch Parameter and template values to synchronised template job

* fix bucket name

* Feature/cw metadata (#65)

* add loggroup to metadata

* added support for X86

* v1.0.1

* align cargo.toml version with template version

* fix bucket name for dev sync (#70)

* allow sync to run manually (#71)

* Custom Lambda Addition (#74)

* add support for multiple msk topic (#75)

* Cloudwatch subscription update [CDS-1120] (#79)

* update the cloudwatch custom lambda to delete subscription after lambda deletion

* update Policies

* update changelog

* csv custome header added (#76)


---------

Co-authored-by: Concourse <[email protected]>

* added test to custom metadata and csv header

---------

Co-authored-by: guyrenny <[email protected]>
Co-authored-by: Concourse <[email protected]>

* Cloudwatch integration update custom lambda [CDS-1136] (#80)

* Update cloudwatch custom lambda so it will be possible to see log group as trigger

* update permission

* remove depend on

* v1.0.3

* align cargo.toml version with template version

* fixed typo

* Cds 756 Add DLQ Support (#85)

* added functionality to handle nested sqs events using receursion

added s3 upload function for failed sqs retry limits

* add sqs config values

* modify parameters to handler function to use new clients type

* updated tests to use the new clients type

added tests for dlq flow

* added new dependencies

* removed unused imports

* remove comments

* commented out unused variables

* cargo fmt

* cargo fmt

* added test for CloudWatch failure dlq event and modified s3 dlq event

* added anyhow

* adjusted how s3 object keys are presented in for S3 and Cloudwatch objects on dlq

* update tests

* added debug prints

updated dlq s3 event workflow to store original event if object is unavailable

* added DLQ support for DLQ. merged all custom resource code into one parameter
based function and added functionality to the custom resource to allow
it to configure lambda for DLQ

* cargo.lock

* changelog

* update readme

* added default retry delay

* add location for static files

* updated readme

* removed cds from changelog

---------

Co-authored-by: juan-coralogix <[email protected]>
Co-authored-by: Concourse <[email protected]>
Co-authored-by: juan-coralogix <[email protected]>
Co-authored-by: guyrenny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants