-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cds 756 Add DLQ Support #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added s3 upload function for failed sqs retry limits
added tests for dlq flow
updated dlq s3 event workflow to store original event if object is unavailable
…arameter based function and added functionality to the custom resource to allow it to configure lambda for DLQ
juan-coralogix
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
daidokoro
added a commit
that referenced
this pull request
Apr 23, 2024
* cargo * Feature/ecr tests (#63) ECR Tests added * add env variable to control architecture selection in Makefile * added x86_64 build path to publish workflows * added CpuArch Parameter and template values to synchronised template job * fix bucket name * Feature/cw metadata (#65) * add loggroup to metadata * added support for X86 * v1.0.1 * align cargo.toml version with template version * fix bucket name for dev sync (#70) * allow sync to run manually (#71) * Custom Lambda Addition (#74) * add support for multiple msk topic (#75) * Cloudwatch subscription update [CDS-1120] (#79) * update the cloudwatch custom lambda to delete subscription after lambda deletion * update Policies * update changelog * csv custome header added (#76) --------- Co-authored-by: Concourse <[email protected]> * added test to custom metadata and csv header --------- Co-authored-by: guyrenny <[email protected]> Co-authored-by: Concourse <[email protected]> * Cloudwatch integration update custom lambda [CDS-1136] (#80) * Update cloudwatch custom lambda so it will be possible to see log group as trigger * update permission * remove depend on * v1.0.3 * align cargo.toml version with template version * fixed typo * Cds 756 Add DLQ Support (#85) * added functionality to handle nested sqs events using receursion added s3 upload function for failed sqs retry limits * add sqs config values * modify parameters to handler function to use new clients type * updated tests to use the new clients type added tests for dlq flow * added new dependencies * removed unused imports * remove comments * commented out unused variables * cargo fmt * cargo fmt * added test for CloudWatch failure dlq event and modified s3 dlq event * added anyhow * adjusted how s3 object keys are presented in for S3 and Cloudwatch objects on dlq * update tests * added debug prints updated dlq s3 event workflow to store original event if object is unavailable * added DLQ support for DLQ. merged all custom resource code into one parameter based function and added functionality to the custom resource to allow it to configure lambda for DLQ * cargo.lock * changelog * update readme * added default retry delay * add location for static files * updated readme * removed cds from changelog --------- Co-authored-by: juan-coralogix <[email protected]> Co-authored-by: Concourse <[email protected]> Co-authored-by: juan-coralogix <[email protected]> Co-authored-by: guyrenny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for enabling a DLQ for the coralogix-aws-shipper lambda function.
How Has This Been Tested?
Checklist: