Conversation
|
PR author is not in the allowed authors list. |
|
this is the right pr to merge over #1196 (more complete, covers genesis scripts too). one concern before merge: no param migration. any chain initialized with default params already has |
aljo242
left a comment
There was a problem hiding this comment.
needs param migration for existing chains that already have the vesting precompile address in state.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
14e5670 to
7635b75
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 67.58% 67.60% +0.01%
==========================================
Files 321 322 +1
Lines 23467 23476 +9
==========================================
+ Hits 15861 15871 +10
+ Misses 6426 6425 -1
Partials 1180 1180
🚀 New features to boost your workflow:
|
Description
This PR removes the nonexistent vesting static precompile address from the default active static precompile list.
The vesting precompile address was listed in
AvailableStaticPrecompiles, but there is noprecompiles/vestingimplementation and no corresponding static precompile registration inDefaultStaticPrecompiles. This could make0x0000000000000000000000000000000000000803active in params without a registered implementation.Closes: #1192
Author Checklist
I have...
mainbranchReview instructions:
0x0000000000000000000000000000000000000803is no longer included in default/manual active static precompile lists.go test -tags=test ./x/vm/types ./x/vm/keeper.