Skip to content

fix(vm): remove nonexistent vesting static precompile - #1193

Open
nowooj wants to merge 2 commits into
cosmos:mainfrom
nowooj:fix/unuse-vesting
Open

nowooj wants to merge 2 commits into
cosmos:mainfrom
nowooj:fix/unuse-vesting

Conversation

@nowooj

@nowooj nowooj commented May 21, 2026

Copy link
Copy Markdown
Contributor

Description

This PR removes the nonexistent vesting static precompile address from the default active static precompile list.

The vesting precompile address was listed in AvailableStaticPrecompiles, but there is no precompiles/vesting implementation and no corresponding static precompile registration in DefaultStaticPrecompiles. This could make 0x0000000000000000000000000000000000000803 active in params without a registered implementation.

Closes: #1192


Author Checklist

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Review instructions:

  • Confirm 0x0000000000000000000000000000000000000803 is no longer included in default/manual active static precompile lists.
  • Confirm existing precompile addresses are not renumbered.
  • Confirm tests pass with go test -tags=test ./x/vm/types ./x/vm/keeper.

@nowooj
nowooj requested a review from a team as a code owner May 21, 2026 01:38
@greptile-apps

greptile-apps Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

PR author is not in the allowed authors list.

@aljo242

aljo242 commented May 26, 2026

Copy link
Copy Markdown
Contributor

this is the right pr to merge over #1196 (more complete, covers genesis scripts too). one concern before merge:

no param migration. any chain initialized with default params already has 0x0000000000000000000000000000000000000803 in active_static_precompiles state. if ValidateBasic checks enabled precompiles against AvailableStaticPrecompiles, those chains will fail param validation on upgrade. needs a migration to strip the address from existing state, or confirmation that it is safe to skip.

@aljo242 aljo242 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs param migration for existing chains that already have the vesting precompile address in state.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

@nowooj
nowooj requested a review from aljo242 September 17, 2026 02:56
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.60%. Comparing base (6cc4bde) to head (7635b75).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
+ Coverage   67.58%   67.60%   +0.01%     
==========================================
  Files         321      322       +1     
  Lines       23467    23476       +9     
==========================================
+ Hits        15861    15871      +10     
+ Misses       6426     6425       -1     
  Partials     1180     1180              
Files with missing lines Coverage Δ
x/vm/migrations/v2/store.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Remove nonexistent vesting precompile address

2 participants