Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable free-threaded wheel builds #107

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ngoldbaum
Copy link
Contributor

@ngoldbaum ngoldbaum commented Dec 2, 2024

Fixes #101

Thanks for working with me on this, myself and @davidhewitt were able to catch a number of issues with packaging free-threaded wheels for rust/python/pyo3 packages using this and some of the pydantic and cryptography dependencies.

At least on my fork, I'm able to successfully build free-threaded wheels using this commit.

Note that this contains an unrelated change to the sdist generation on CI, because that was unnecessarily installing a bunch of different python versions.

🥳

@Julian
Copy link
Member

Julian commented Dec 2, 2024

Hooray!

Thanks for working with me on this

Thank you for pushing it forward, it never would have happened otherwise (not least of which because this isn't functionality I care about, but I'm very happy to support it in exactly the case that happened, i.e. you helping!)

The changes here (including what you noted) match what I did on the ft-wheels branch, which I didn't merge because it was/is waiting on twine to unbreak itself. It looks like that has now happened considering we're green, so I'll merge.

Thanks again. P.S. I'd offer you commit bit on this repo if you'd like to continue to help out in any way with this sort of thing -- though of course it's a blessing and a curse as with anything. But just mentioning that I appreciate it! Ping if you care for it.

@Julian Julian merged commit 1832211 into crate-py:main Dec 2, 2024
36 checks passed
@Julian
Copy link
Member

Julian commented Dec 2, 2024

pypa/trove-classifiers#195 looks unmerged, so no trove classifier to add it seems yet. But a release will go out in a minute.

@ngoldbaum
Copy link
Contributor Author

But just mentioning that I appreciate it! Ping if you care for it.

Thanks for the offer, hopefully support is pretty much autopilot from here. Let's not give me a commit bit unless this package comes up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ship free-threaded wheels
2 participants