Fixes support subscription cancelation

[eliduke]

The stripe gem deprecated subscription delete. The new way is now cancel.

What does this pull request do?

This should fix the issue with canceling subscriptions, like this...

How should this be manually tested?

Yes, I will try canceling my subscription once this goes live.

[just1602]

@eliduke I merged it, but I don't have the access to promote to production, so @veganstraightedge will have to do it.

[eliduke]

btw, I finally got around to testing this and confirmed that it is indeed working! I was able to cancel my subscription. The only problem now is that I'm realizing that I'm not seeing any flash notices appear at any point. We've got a bunch of them in place in the support controller for a number of things. Upon further inspection, I'm seeing a bunch of different syntax like...

flash[:notice]
flash.now[:notice]
flash.now.alert

Are flash notices still working? Did the syntax get updated? I'm seeing some stuff regarding "themes" (2017 or 2020) and it seems like the flash notice partial isn't available in 2020.

Thoughts?

[just1602]

@eliduke rubocop enforce flash.new[:flash_type] syntax, but both are supposed to work.

Otherwise, you should check in the 2017 theme, the 2020 theme never got fully implemented due to covid and people having less time for the project.

[bensheldon]

hopefully helpful: ☺️

flash.now should be used when the message is to be shown when the current request's template is rendered i.e. it's not a redirect.

I think that flash[:type] likely shouldn't be used, and flash messages instead should be added to the redirect_to the_path, flash: { type: "message" }

(And yes, the theme should be double checked that they are rendered)