[twizzle/edit] Improve UX if you keep changing notation when auto-not…

…ation is disabled.
cubing · Oct 9, 2024 · 06e9a79 · 06e9a79
1 parent 103d05c
commit 06e9a79
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 22 deletions.
diff --git a/src/sites/alpha.twizzle.net/edit/app.ts b/src/sites/alpha.twizzle.net/edit/app.ts
@@ -158,10 +158,6 @@ export class App {
   #autofixEnabled: boolean = true;
   // TODO: factor this out into a class
   async #onSetupOrAlgChange() {
-    console.log(this.#autofixEnabled);
-    if (!this.#autofixEnabled) {
-      return;
-    }
     (async () => {
       const [originalPuzzleID, puzzleAlgWithIssue, puzzleSetupAlgWithIssue] =
         await Promise.all([
@@ -195,29 +191,31 @@ export class App {
               this.#autoNotationPuzzleOld = originalPuzzleID;
               this.#autoNotationPuzzleNew = puzzleID;
 
-              for (const elem of this.element.querySelectorAll(
-                ".auto-notation-puzzle-old",
-              )) {
-                elem.textContent = puzzles[originalPuzzleID].fullName;
-              }
               for (const elem of this.element.querySelectorAll(
                 ".auto-notation-puzzle-new",
               )) {
                 elem.textContent = puzzleLoader.fullName;
               }
 
-              this.element.querySelector<HTMLSpanElement>(
-                ".auto-notation",
-              )!.hidden = false;
-              this.element.querySelector<HTMLSpanElement>(
-                ".auto-notation-change-back",
-              )!.hidden = false;
-              this.element.querySelector<HTMLSpanElement>(
-                ".auto-notation-change-redo",
-              )!.hidden = true;
-
-              this.controlPane.puzzleSelect.value = puzzleID;
-              this.controlPane.puzzleSelectChanged();
+              if (this.#autofixEnabled) {
+                for (const elem of this.element.querySelectorAll(
+                  ".auto-notation-puzzle-old",
+                )) {
+                  elem.textContent = puzzles[originalPuzzleID].fullName;
+                }
+                this.element.querySelector<HTMLSpanElement>(
+                  ".auto-notation",
+                )!.hidden = false;
+                this.element.querySelector<HTMLSpanElement>(
+                  ".auto-notation-change-back",
+                )!.hidden = false;
+                this.element.querySelector<HTMLSpanElement>(
+                  ".auto-notation-change-redo",
+                )!.hidden = true;
+
+                this.controlPane.puzzleSelect.value = puzzleID;
+                this.controlPane.puzzleSelectChanged();
+              }
               return;
             }
           } catch {}

diff --git a/src/sites/alpha.twizzle.net/edit/index.html b/src/sites/alpha.twizzle.net/edit/index.html
@@ -33,7 +33,7 @@
               back to <span class="auto-notation-puzzle-old">—</span></a>?</span><span
             class="auto-notation-change-redo">Auto-detection has been temporarily disabled. Want to <a href="#"
               class="auto-notation-redo">re-enable it and change the puzzle to
-              to <span class="auto-notation-puzzle-new">—</span></a> again?</span>)
+              to <span class="auto-notation-puzzle-new">—</span></a>?</span>)
         </p>
       </div>
       <expand-button for="setup" expanded="true" exclusive="false">