Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webots_ros2_control: remove usage of deprecated activate_all_compone… #901

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

skpawar1305
Copy link
Contributor

@skpawar1305 skpawar1305 commented Feb 20, 2024

…nts for humble

ros-controls/ros2_control#1064

Description
activate_all_components is deprecated. it'll still work though

Affected Packages
List of affected packages:

  • webots_ros2_control

@skpawar1305 skpawar1305 force-pushed the skpawar1305/remove_activate_all_components branch from a57bed6 to 2ea7fe2 Compare February 20, 2024 05:27
@omichel omichel added this to the 2023.1.2 milestone Feb 20, 2024
@omichel omichel self-requested a review February 20, 2024 07:45
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@omichel
Copy link
Member

omichel commented Feb 20, 2024

Your PR is still in draft, is that on purpose?

@skpawar1305 skpawar1305 marked this pull request as ready for review February 20, 2024 10:16
@skpawar1305
Copy link
Contributor Author

Your PR is still in draft, is that on purpose?

yes, wanted to check the tests

@omichel omichel merged commit 97a007f into master Feb 20, 2024
9 of 14 checks passed
@omichel omichel deleted the skpawar1305/remove_activate_all_components branch February 20, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants