Merge pull request #621 from nuclearkatie/source_packaging

prevent underflow when not enough material is available to make a packagable bid
cyclus · Sep 13, 2024 · 58650fe · 58650fe
2 parents dce0237 + f3637af
commit 58650fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -7,7 +7,7 @@ Since last release
 
 **Added:**
 * Added package parameter to storage (#603, #612, #616)
-* Added package parameter to source (#613, #617)
+* Added package parameter to source (#613, #617, #621)
 * Added default keep packaging to reactor (#618, #619)
 
 **Changed:**

diff --git a/src/source.cc b/src/source.cc
@@ -102,8 +102,9 @@ std::set<cyclus::BidPortfolio<cyclus::Material>::Ptr> Source::GetMatlBids(
     double qty = std::min(target->quantity(), max_qty);
 
     // calculate packaging
-    double bid_qty = context()->GetPackage(package)->GetFillMass(qty);
-    int n_full_bids = static_cast<int>(std::floor(qty / bid_qty));
+    std::pair<double, int> fill = context()->GetPackage(package)->GetFillMass(qty);
+    double bid_qty = fill.first;
+    int n_full_bids = fill.second;
     Package::ExceedsSplitLimits(n_full_bids);
 
     std::vector<double> bids;