Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update running browser button icon styling #30851

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Jan 9, 2025

Additional details

The disabled button styling changed in the design system. Updated the styling of the icon to match the new styling.

Steps to test

n/a

How has the user experience changed?

Before:
Screenshot 2025-01-09 at 10 15 20 AM

After:
Screenshot 2025-01-09 at 10 13 29 AM

Cypress 13:
Screenshot 2025-01-09 at 10 16 15 AM

PR Tasks

@mschile mschile self-assigned this Jan 9, 2025
@jennifer-shehane jennifer-shehane self-requested a review January 9, 2025 17:24
Copy link

cypress bot commented Jan 9, 2025

cypress    Run #59791

Run Properties:  status check passed Passed #59791  •  git commit 6c1a9f68a9: Merge branch 'develop' into mschile/running_browser_icon_styling
Project cypress
Branch Review mschile/running_browser_icon_styling
Run status status check passed Passed #59791
Run duration 17m 11s
Commit git commit 6c1a9f68a9: Merge branch 'develop' into mschile/running_browser_icon_styling
Committer Matt Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 77
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5597
View all changes introduced in this branch ↗︎

Warning

No Report: Something went wrong and we could not generate a report for the Application Quality products.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that it is.....better. I'd love to spend some time revisiting the a11y of all of our UI at some point with our a11y insight. 🤞🏻

@mschile mschile merged commit 056696c into develop Jan 9, 2025
89 checks passed
@mschile mschile deleted the mschile/running_browser_icon_styling branch January 9, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cy 14] Incorrect icon styling for the running browser button
2 participants