Skip to content

Update Cython to latest #110

Closed
Closed

Description

@GoogleCodeExporter

A thorough testing will be required, as version 0.20 breaks some things. While
doing a quick testing, one issue was found so far.

Issue with strings

The Debug() function needs to accept both unicode and bytes strings. In version 0.19.2 of Cython you could pass unicode string and it was converted automatically, but with the new version an error is throwed:

 TypeError: Expected str, got unicode

The Debug() function:
https://code.google.com/p/cefpython/source/browse/cefpython/utils.pyx?r=2f6f611c2fcf#20

Called from CreateJavascriptCallback():
https://code.google.com/p/cefpython/source/browse/cefpython/javascript_callback_cef3.pyx?r=2f6f611c2fcf

The functionName param was decoded from the cefpython IPC message using the json library, and the json library automatically converted the string to unicode.

There might be more places where unicode is passed and it would throw an error.

Activity

  1. added this to the milestone on Jan 26, 2016
  2. changed the title [-]Update Cython to version 0.20[/-] [+]Update Cython to the latest Cython 0.23.4[/+] on Feb 12, 2016
  3. modified the milestones: , on Feb 12, 2016
  4. changed the title [-]Update Cython to the latest Cython 0.23.4[/-] [+]Update to the latest Cython 0.23.4[/+] on Feb 12, 2016
  5. 2 remaining items

  6. changed the title [-]Update to the latest Cython 0.23.4[/-] [+]Update to Cython 0.24.1[/+] on Sep 17, 2016
  7. added a commit that references this issue on Sep 17, 2016
  8. cztomczak commented on Sep 17, 2016

    @cztomczak
    Owner

    Updated to Cython 0.24.1 in commit 6f0d9b3. The issue with strings is not yet fixed in all places (eg. Debug func), further testing is required. Tested only with hello_world.py example.

  9. added a commit that references this issue on Sep 18, 2016
  10. changed the title [-]Update to Cython 0.24.1[/-] [+]Update Cython version[/+] on Oct 28, 2016
  11. changed the title [-]Update Cython version[/-] [+]Update Cython to latest[/+] on Dec 9, 2016
  12. cztomczak commented on Dec 15, 2016

    @cztomczak
    Owner

    Updated to Cython 0.25.2 with no problems.

  13. modified the milestones: v55, on Feb 24, 2017
  14. cztomczak commented on Aug 17, 2018

    @cztomczak
    Owner

    See #250 for future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions