Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump colored crate for true color support #70

Closed
wants to merge 2 commits into from

Conversation

orhun
Copy link

@orhun orhun commented Sep 11, 2020

I realized that colored crate is outdated in fern and checked it's changelog to see if there's any breaking changes. Apparently there's not an outstanding change expect the true color support which is added in the latest (2.0.0) release.

So this PR bumps the version of colored crate to support true colors. (115710b)
I also updated the pretty-colored example for demonstrating the use of true colors. (e419505)

@fvacek
Copy link

fvacek commented Feb 21, 2021

Any progress?

@orhun
Copy link
Author

orhun commented Feb 21, 2021

Any progress?

I released a fork of fern on crates.io since the maintainer was quiet for the past 5 months: https://crates.io/crates/fern_colored

@daboross
Copy link
Owner

daboross commented Feb 22, 2021

My apologies - I must have missed this pull request.

As fern re-exports types from colored, I'd prefer this upgrade is done through an additional colored-2 feature, rather than an in-place upgrade. This would allow this upgrade to a minor version, rather than a major version release of fern. I can do that change; though.

@daboross
Copy link
Owner

The fork does seem justified, though :) . I've not been the most active fern maintainer, especially the past year or two. Hoping I can get this and a few other PRs actually merged and clean things up a bit, but it has been a while. That and evaluate things like #67, which may be worthwhile.

With this, #66 and #65, maybe it would be worthwhile to just upgrade all dependencies and make that a new major release of fern.... Unsure. Seems like we should be able to do without it, but the codebase will just keep getting more convoluted, and log 0.5 is coming much, much slower than I expected it to.

@fvacek
Copy link

fvacek commented Feb 28, 2021

I suggest to make more simple steps. For output coloring:

  1. create colored-2 feature to give user opportunity to use latest version of log package
  2. Then we can start to think about owo coloring, if it worth to be implemented or not.

The syslog issues might be solved in separate as not related to coloring

@daboross
Copy link
Owner

I'm going to close this in favor of future owo-colors support (#67), for reasons listed above.

@daboross daboross closed this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants