Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added correct calculation of offset #231

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added correct calculation of offset #231

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d73903
Added correct calculation of offset
rramaa Oct 13, 2019
69924b4
Merge branch 'master' into patch-4
rramaa Nov 18, 2023
80ef9eb
Merge branch 'master' into patch-4
rramaa Nov 18, 2023
119dfc1
Merge branch 'master' into patch-4
rramaa Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/InfiniteScroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,15 @@ export default class InfiniteScroll extends Component {
} else if (this.props.isReverse) {
offset = parentNode.scrollTop;
} else {
offset = el.scrollHeight - parentNode.scrollTop - parentNode.clientHeight;
let relativeHeight =
el.getBoundingClientRect().top +
parentNode.scrollTop -
parentNode.getBoundingClientRect().top;
offset =
relativeHeight +
el.scrollHeight -
parentNode.scrollTop -
parentNode.clientHeight;
}

// Here we make sure the element is visible as well as checking the offset
Expand Down