In generated field name, an undescore is introduced after a number #657

Activity

1. YodaEmbedding

   added

   bugSomething isn't workingSomething isn't working

   investigation needed

   on Jan 27, 2025
2. YodaEmbedding commented on Mar 16, 2025

   

   YodaEmbedding

   on Mar 16, 2025

   Last edited by YodaEmbedding

   Author

   More actions

   Proposed fix:

   diff --git a/src/betterproto/casing.py b/src/betterproto/casing.py
   index f7d0832..d09c708 100644
   --- a/src/betterproto/casing.py
   +++ b/src/betterproto/casing.py
   @@ -8,11 +8,11 @@ SYMBOLS = "[^a-zA-Z0-9]*"
    
    # Optionally capitalized word.
    # language=PythonRegExp
   -WORD = "[A-Z]*[a-z]*[0-9]*"
   +WORD = "[A-Z]*([a-z]|[0-9][A-Z]*)*"
    
    # Uppercase word, not followed by lowercase letters.
    # language=PythonRegExp
   -WORD_UPPER = "[A-Z]+(?![a-z])[0-9]*"
   +WORD_UPPER = "([A-Z]+(?![a-z])[0-9]*)+"
    
    
    def safe_snake_case(value: str) -> str:

   Tests:

   >>> betterproto.casing.snake_case("C2S2C c2s2c")
   'c2s2c_c2s2c'
   
   >>> betterproto.casing.snake_case("Client2Server CLIENT2SERVER client2Server")
   'client2server_client2server_client2server'
   
   >>> betterproto.casing.snake_case("clientToServer")
   'client_to_server'

   Much nicer. :)