Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add reader page to show publizon reader and enhance work page layout with smartLink #55

Merged
merged 8 commits into from
Nov 27, 2024
Merged

feat: add reader page to show publizon reader and enhance work page layout with smartLink #55

merged 8 commits into from
Nov 27, 2024

Conversation

ThomasGross
Copy link
Contributor

@ThomasGross ThomasGross commented Nov 22, 2024 •
edited
Loading

Link to issue

https://reload.atlassian.net/browse/DDFBRA-200

Description

This PR contains:

  • A /read page to show publizon ebooks
  • SmartLink component to handle internal and external links
  • Changes to url resolver

@spaceo spaceo self-requested a review November 22, 2024 13:17
spaceo
spaceo reviewed Nov 22, 2024
View reviewed changes
app/[id]/loadArticle.ts Outdated Show resolved Hide resolved
spaceo
spaceo reviewed Nov 22, 2024
View reviewed changes
app/[id]/page.tsx Outdated Show resolved Hide resolved
spaceo
spaceo requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I have one question about path to articles.

@ThomasGross ThomasGross requested a review from spaceo November 25, 2024 15:27
spaceo
spaceo approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Ship it goddammit!

@ThomasGross ThomasGross merged commit 7db9ba9 into main Nov 27, 2024
9 checks passed
@ThomasGross ThomasGross deleted the DDFBRA-200-anonym-og-indlogget-bruger-kan-prove-e-bog branch November 27, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaceo spaceo spaceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasGross @spaceo @Adamik10