Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xstate fixes #63

Merged
merged 15 commits into from
Nov 28, 2024
Merged

Xstate fixes #63

merged 15 commits into from
Nov 28, 2024

Conversation

spaceo
Copy link
Contributor

@spaceo spaceo commented Nov 28, 2024 •
edited
Loading

Link to issue

https://reload.atlassian.net/browse/DDFBRA-130

Description

This PR adresses the behaviour that changed after the transition to use Xstate in searching/filtering.
Things being handled:

  • The skeleton screen on load more
  • The behaviour around deleting last character in the search field (which was actually working as intended, but I agree in an oddly manner 😆 )
  • The weird issue about FBI sending one kind of facet names from service and expecting another as input (lix -> lixRange)
  • Changing the way filters where toggled and detected as being active (that was not handled after the inital xstate introduction)
  • Allowing the end user to type and filter while requests are ongoing

@ThomasGross ThomasGross self-requested a review November 28, 2024 08:24
@spaceo
Set the react query client cache staletime in client
afc2586 
We go with 5 min for now.
@spaceo
Make sure that filters are fully removed when removing last item
30b9e74 
This makes sure that we can use the fully advantage of the query client
cache.
@spaceo
Remove UX handling search string deleted
641cc6d 
We do not need the implemented behaviour. Eg.: We should not search when
search string is deleted.
@spaceo
Remove unsused functions
e1b85e5 
Since the refactoring of the search state handling to Xstate these
functions are no more needed
@spaceo
Translating facet response to input search filters
45b5708 
For some reason they are diffrent. Eg. lix => lixRange
@spaceo
Fix problem about facet result names not matching input filters
8816384 
Lix -> lixRange is the main problem.
This PR fixes the problem by translating the filter right after the
facets have been fecthed. The translated facet name lives through the
rest of the life cycle and is being sent to the next requests.
@spaceo
Allow typing and search during fetch requests
70340f8 
By adding the events in the state tree under the "filteringAndSearching"
state.
@spaceo
Make toggle filer work in both desktop and mobile
38688e1
@spaceo
Use selectedFilters as single source of trouth in mobile filters
a71a5d5 
Since the filters are handled in the state machine
ThomasGross
ThomasGross approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@ThomasGross ThomasGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥳

__tests__/search.test.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice with some test on the facets!

@spaceo spaceo merged commit eb2cf25 into main Nov 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasGross ThomasGross ThomasGross approved these changes

Assignees

@ThomasGross ThomasGross

@Adamik10 Adamik10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaceo @ThomasGross @Adamik10