Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Blue title" badge for cost free works on work page #67

Merged
merged 17 commits into from
Dec 6, 2024

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Dec 3, 2024

Link to issue

https://reload.atlassian.net/browse/DDFBRA-173
https://reload.atlassian.net/browse/DDFBRA-248

Description

This PR:

  • adds the blue title badge above the work title on work page for works that are cost free
  • improves work title breaking into multiple lines based on the language ISO code that we can get from FBI API
  • fixes minor bugs
  • adds selected manifestation type to the URL on material page

Screenshot of the result

Additional comments or questions

Copy link
Contributor

@ThomasGross ThomasGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have some comments.

Jeg tried running the code and the switch seems to be working in the opposite way as intended. (when click on the active manifestation it switches)

Also It could be nice to show the same icons on the switch as on the cards on the search result page. 😊

components/pages/workPageLayout/WorkPageHeader.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ThomasGross ThomasGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Adamik10 Adamik10 merged commit 9951c2e into main Dec 6, 2024
10 checks passed
@Adamik10 Adamik10 deleted the DDFBRA-173-bruger-skal-kunne-se-bla-titel branch December 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants