Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AKS to 1.26 #215

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Upgrade AKS to 1.26 #215

merged 1 commit into from
Jan 16, 2024

Conversation

achton
Copy link
Contributor

@achton achton commented Dec 15, 2023

What does this PR do?

This commits the current version of the AKS cluster post-upgrade via Terraform.

Should this be tested by the reviewer and how?

Azure Portal should display the current version of the cluster, which should match this PR.

@achton achton force-pushed the feature/upgrade-aks-1.26 branch from ca3e230 to 7d06181 Compare December 15, 2023 12:00
@achton achton self-assigned this Dec 15, 2023
@achton achton requested a review from spaceo December 15, 2023 12:03
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks god. Have one question though

Comment on lines -12 to -17
variable "cluster_upgrade_channel" {
description = "Which channel to use for automatic cluster upgrades. Valid values are 'stable', 'rapid', 'patch' and 'node-image'."
type = string
default = "patch"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a complete terraform novice.
But isn't there supposed to be a control_plane_version variable block in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it's there - in line 7 😉

@achton achton requested a review from spaceo January 9, 2024 09:05
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@achton achton merged commit 5347cba into main Jan 16, 2024
3 checks passed
@achton achton deleted the feature/upgrade-aks-1.26 branch January 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants