Install openssh in dplsh to ensure we can run ssh-related commands inside it #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side it The guide in [the guide for provisioning Github repos](/docs/runbooks/add-library-site-to-platform.md) step 2 suggests running ssh-agent and ssh-add inside dplsh, but these do not work as openssh is missing from the shell. To make it easier to run everything inside the shell, we add the missing dependency, so the guide is now correct.
hypesystem
force-pushed
the
enable-ssh-in-dplsh
branch
from
c50118c to
f895b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The guide in the guide for provisioning Github repos step 2 suggests running
ssh-agentandssh-addinside dplsh, but these do not work as openssh is missing from the shell.To make it easier to run everything inside the shell, we add the missing dependency, so the guide is now correct.
Should this be tested by the reviewer and how?
Build dplsh locally (
docker build . -t dplsh:localin the /tools/dplsh folder, run the dplsh (DPLSH_IMAGE=dplsh:local ../tools/dplsh/dplsh.shin the /infrastructure folder) and verify thatssh-agentandssh-addexecute without errors in the shell.Any specific requests for how the PR should be reviewed?
N/A
What are the relevant tickets?
N/A