add a step to remind us to update the kubectl version to match the AK… #319
Conversation
docs/runbooks/upgrading-aks.md
Outdated
| @@ -86,3 +86,4 @@ Monitor via eg. | |||
| ```shell | |||
| watch -n 5 kubectl get nodes | |||
| ``` | |||
| 5. Go to `dplsh's` Dockerfile and update the `kubectl` version to match that of the upgraded AKS version | |||
There was a problem hiding this comment.
Overvej at lave en runbook til hvordan man udgiver en ny version af dplsh, og link til den her. Det gør man sådan her:
- Lav ændringerne i dplsh directory'et
- Byg lokalt med
IMAGE_URL=dplsh IMAGE_TAG=local task buildi dplsh mappen - Test at det virker med
DPLSH_IMAGE=dplsh:local ./dplsh - Tjek release version her: https://github.com/danskernesdigitalebibliotek/dpl-platform/releases
- Push en branch og få review. Merge til master.
- Push et tag af formen
dplsh-x.x.xpå master - så bygger og releaser den automatisk.
Derudover: variablen i dplsh hedder KUBECTL_VERSION :-)
There was a problem hiding this comment.
Test evt. processen ifbm at du skriver en runbook, det tror jeg er en god øvelse.
There was a problem hiding this comment.
Jeg har lavet det som et nyt PR :)
There was a problem hiding this comment.
The Ordered list item prefix error can be ignored here, c.f. https://github.com/DavidAnson/markdownlint?tab=readme-ov-file#configuration
ITViking
force-pushed
the
update-aks-upgrade-runbook
branch
from
e41fd64 to
abb7980
Compare
docs/runbooks/upgrading-aks.md
Outdated
| @@ -86,3 +86,4 @@ Monitor via eg. | |||
| ```shell | |||
| watch -n 5 kubectl get nodes | |||
| ``` | |||
| 5. Go to `dplsh's` Dockerfile and update the `kubectl` version to match that of the upgraded AKS version | |||
There was a problem hiding this comment.
The Ordered list item prefix error can be ignored here, c.f. https://github.com/DavidAnson/markdownlint?tab=readme-ov-file#configuration
ITViking
force-pushed
the
update-aks-upgrade-runbook
branch
from
4e3bfdd to
0ce5d64
Compare
What does this PR do?
It add a another step to the upgrade AKS runbook to remind people that the kubectl version should also be updated to match that of the AKS kubernetes version
Should this be tested by the reviewer and how?
Any specific requests for how the PR should be reviewed?
What are the relevant tickets?