automatically adjust pr envs resource request #560
+95
−0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| apiVersion: v2 | ||
| name: patch-pr-env-resource-requests | ||
| version: 0.0.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| apiVersion: batch/v1 | ||
| kind: CronJob | ||
| metadata: | ||
| name: patch-resource-requests | ||
| namespace: default | ||
| spec: | ||
| schedule: "0 */6 * * *" # Every 6 hours | ||
| jobTemplate: | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: patch-resources | ||
| image: bitnami/kubectl:latest | ||
| command: | ||
| - /bin/sh | ||
| - -c | ||
| - | | ||
| #!/bin/sh | ||
| for ns in $(kubectl get ns --no-headers -o custom-columns=":metadata.name" | grep -E "dpl-cms-pr|dpl-bnf-pr"); do | ||
| for deploy in nginx redis varnish cli; do | ||
| if kubectl get deployment $deploy -n $ns > /dev/null 2>&1; then | ||
| echo "Patching deployment $deploy in namespace $ns" | ||
| case $deploy in | ||
| nginx) | ||
| memory_request=160Mi | ||
| memory_limit=256Mi | ||
| ;; | ||
| redis) | ||
| memory_request=60Mi | ||
| memory_limit=256Mi | ||
| ;; | ||
| varnish) | ||
| memory_request=180Mi | ||
| memory_limit=256Mi | ||
| ;; | ||
| cli) | ||
| memory_request=25Mi | ||
| memory_limit=125Mi | ||
| ;; | ||
| *) | ||
| memory_request=150Mi | ||
| memory_limit=256Mi | ||
| ;; | ||
| esac | ||
| # TODO: we could look into away of checking if the patching of a deployment went well, so we dont have to sleep | ||
| kubectl patch deployment $deploy -n $ns \ | ||
| --type=json \ | ||
| -p="[{\"op\": \"replace\", \"path\": \"/spec/template/spec/containers/0/resources\", \"value\": {\"requests\": {\"cpu\": \"15m\", \"memory\": \"$memory_request\"}, \"limits\": {\"cpu\": \"200m\", \"memory\": \"$memory_limit\"}}}]" | ||
| else | ||
| echo "Deployment $deploy not found in namespace $ns" | ||
| fi | ||
| done | ||
| echo "sleeping for a minute to give the deployments time to get back up and not crash the database" | ||
| sleep 60 | ||
|
There was a problem hiding this comment. Hmm, I think my take on this is that it is potentially creating a lot of work on the Kubernetes API server if we patch everything every minute? Could we find a way to directly query if the deployments have their memory limits set correctly before trying to set them? Looking into this, will report back if I find a good approach. There was a problem hiding this comment. Beginning of something: kubectl get deploy -n $ns -o json | jq '.items[] | { name: .metadata.name, resources: .spec.template.spec.containers[0].resources }'produces a list of JSON objects each with a name and the resource spec. Next up, picking those that do not match the desired memory limit and request. There was a problem hiding this comment. kubectl get deploy -n $ns -o json | jq '.items[] | [.metadata.name, .spec.template.spec.containers[0].resources.limits.memory, .spec.template.spec.containers[0].resources.requests.memory] | join(",")' --raw-outputThis outputs a list of the format: <deploymentname>,<memorylimit>,<memoryrequest>To get a particular list of deployments, we can append this to the command (selecting | grep -E '^(nginx|redis|varnish|cli),([0-9]+[A-Za-z]+|),([0-9]+[A-Za-z]+|)$'If we save the output of the above as variable deployment_name=`echo $spec | cut -f1 -d,`
current_memory_limit=`echo $spec | cut -f2 -d,`
current_memory_request=`echo $spec | cut -f3 -d,`Now we can decide to only patch if the limit or request differ from the current state. Much fewer requests. When everything is as it should be it means we get the following requests every execution (6 hours):
Whereas before, when we naively patched, we would get:
|
||
| done | ||
| restartPolicy: OnFailure | ||
| serviceAccountName: pr-env-patcher-cronjob-sa | ||
| --- | ||
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: pr-env-patcher-cronjob-sa | ||
| namespace: default | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: deployments-patch-list-get-patch-cluster-role | ||
| rules: | ||
| - apiGroups: [""] | ||
| resources: ["namespaces"] | ||
| verbs: ["list"] | ||
| - apiGroups: ["apps"] | ||
| resources: ["deployments"] | ||
| verbs: ["get", "list", "patch"] | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: namespace-lister-binding | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: pr-env-patcher-cronjob-sa | ||
| namespace: default | ||
| roleRef: | ||
| kind: ClusterRole | ||
| name: deployments-patch-list-get-patch-cluster-role | ||
| apiGroup: rbac.authorization.k8s.io | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/usr/bin/env bash | ||
| helm upgrade patch-pr-env-resource-requests chart \ | ||
| --install |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pin to kubernetes version we know works with our setup.
kubectl may update or we may update cluster to create inconsistency unknowingly - so it's better to be able to control it.