Increase size of NGINX persistent storage to 10Gi #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the size limit currently set by the largest library site. Make this the default for all sites. We currently do not have a good way to set individual size limits per site. This has created a suboptimal workflow where the site in question has to be updated manually after each workflow for the deployment to complete. We could introduce a way to control this per site in sites.yaml but it would not provide much value. We pay for storage used - not reserved. Consequently increasing the limit for all sites should not increase costs considerably until it is actually used. All this in mind we increase the size of the the persistent storage for the Lagoon default of 5Gb to 10Gb. https://docs.lagoon.sh/concepts-basics/docker-compose-yml/#persistent-storage We only need to apply this to one service. We intentionally choose the nginx one as this is the one currently bumped on one library site. Kubernetes will complain if we to try decrease the limit for attached storage. This will occur if we apply this setting to other services.
kasperg
force-pushed
the
bump-nginx-persistent-size
branch
from
71b19bd to
15ba1aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increase size of NGINX persistent storage to 10Gi.
This is the size limit currently set by the largest library site. Make this the default for all sites.
We currently do not have a good way to set individual size limits per site. This has created a suboptimal workflow where the site in question has to be updated manually after each workflow for the deployment to complete.
We could introduce a way to control this per site in sites.yaml but it would not provide much value. We pay for storage used - not reserved. Consequently increasing the limit for all sites should not increase costs considerably until it is actually used.
All this in mind we increase the size of the the persistent storage for the Lagoon default of 5Gb to 10Gb.
https://docs.lagoon.sh/concepts-basics/docker-compose-yml/#persistent-storage
We only need to apply this to one service. We intentionally choose the nginx one as this is the one currently bumped on one library site. Kubernetes will complain if we to try decrease the limit for attached storage. This will occur if we apply this setting to other services.
Should this be tested by the reviewer and how?
As I see it it is pretty hard to review.
Any specific requests for how the PR should be reviewed?
As I see it it is pretty hard to test.
What are the relevant tickets?
https://reload.atlassian.net/browse/DDFDRIFT-245