Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Path for file paths in checkpoint sync #174

Merged
merged 2 commits into from
May 31, 2024
Merged

Use Path for file paths in checkpoint sync #174

merged 2 commits into from
May 31, 2024

Conversation

jmcph4
Copy link
Contributor

@jmcph4 jmcph4 commented May 30, 2024

Motivation

  • It's more correct
  • It means that CLI argument parsing code that uses PathBuf can avoid having to convert to native string types

Solution

Rely on generic P: AsRef<std::path::Path>.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

0xOsiris
0xOsiris approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@0xOsiris 0xOsiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xOsiris 0xOsiris merged commit e06126f into darkforestry:main May 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xOsiris 0xOsiris 0xOsiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcph4 @0xOsiris