-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/div zero #176
Fix/div zero #176
Conversation
"We should really add some unit tests on this function after these changes. Maybe we could separate all peripheral functions into a deployable inherited contract that we can then easily unit test in foundry" Just for this contract? Should we do it in this pull request or make a new one? U wanna make an abstract contract right? |
Another edge case was found: It will still produce a div 0 error if
@0xOsiris thoughts? |
Change log:
|
Yeah, we can isolate this into a different PR though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this! LGTM
ah shit, theres a conflict with .gitignore, will resolve now |
done! |
Motivation
Fix annoying bug related to not enough bits that results in div zero due to very small price number.
Solution
PR Checklist