Conversation
Member
Author
|
@kofa73 : still something wrong with -DBUILD_TESTING=ON & cmoka. |
Collaborator
I think you didn't add any of the new unit tests I sent you in the patch. vs
|
TurboGit
force-pushed
the
security-patch
branch
from
September 16, 2026 11:23
cc06de7 to
cff93c0
Compare
Member
Author
Indeed :( It is a patch and not an direct apply-mail compatible Git item, so I need to explicitly add the new files. Should be fixed, sorry for the noise. |
Collaborator
|
Hold on, there may be one more... will get back to you later |
The iop bound tests were never added to CMake. The history test now expects unterminated char arrays to be skipped.
Add a shared check that a fixed string field lies within the params blob and is terminated, and clamp stored histogram indices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

params: validate stored module parameters before use
Module parameters are deserialized from history, sidecars, styles and presets
as binary data. Some modules used stored counts, indices and fixed-size text
fields without range-checking them, so an invalid or hand-edited parameter
block could misbehave. This bounds those values where they are used: counts
and indices are clamped before indexing, fixed-size text is read within its
field, and the LUT 3D module keeps stored names and paths out of the G'MIC
command line and confines relative paths to the LUT folder.
No parameter layout changes and no migration is needed. Valid edits render as
before. Existing compressed-LUT cache files are regenerated once, because the
cache file name changed.
Adds cmocka coverage for the curve helpers, the fixed-string copy, and the
LUT 3D count, cache-name and path checks.
Contributed by Kofa.