Skip to content

More informative logs about roi changing - #22298

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:improved_roi_changing_logs
Sep 16, 2026
Merged

TurboGit merged 1 commit into
darktable-org:masterfrom
jenshannoschwalm:improved_roi_changing_logs

Conversation

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator

We want -d pipe information about roi changing or not for all modules that specify a modify_roi_in/out() function.
This requires two helpers:
dt_iop_module_modifies_roi_in()
dt_iop_module_modifies_roi_out()
to reduces unwanted output.

Helping to track down some pipe processing issues

No release note required

We want '-d pipe' information about roi changing or not for all modules that specify a
modify_roi_in/out() function.
This requires two helpers:
  dt_iop_module_modifies_roi_in()
  dt_iop_module_modifies_roi_out()
to reduces unwanted output.
@jenshannoschwalm jenshannoschwalm added this to the 5.8 milestone Sep 16, 2026
@jenshannoschwalm jenshannoschwalm added scope: codebase making darktable source code easier to manage scope: debugging labels Sep 16, 2026
@gi-man

gi-man commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Should we include this in -d common too?

@jenshannoschwalm

Copy link
Copy Markdown
Collaborator Author

-d common includes -d pipe :-)

@jenshannoschwalm jenshannoschwalm added Release note provided A release note is either provided in this PR or not required Abstract provided Includes a 5-liner human written abstract labels Sep 16, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit f2db9b9 into darktable-org:master Sep 16, 2026
6 checks passed
@jenshannoschwalm
jenshannoschwalm deleted the improved_roi_changing_logs branch September 16, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Abstract provided Includes a 5-liner human written abstract Release note provided A release note is either provided in this PR or not required scope: codebase making darktable source code easier to manage scope: debugging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants