mockito: avoid generating dummy classes for ProtobufEnum subtypes and GeneratedMessage subtypes - #5011
Open
srawlins wants to merge 3 commits into
Open
mockito: avoid generating dummy classes for ProtobufEnum subtypes and GeneratedMessage subtypes#5011srawlins wants to merge 3 commits into
srawlins wants to merge 3 commits into
Conversation
… GeneratedMessage subtypes
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
Member
Author
|
This has passed internal TGP: OCL:953037152:BASE:980842863:1789347009426:f955819d |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unnamed GeneratedMessage subtype constructor will not have side effects. The first value of a ProtobufEnum subtype will exist. This lets us generate less.
In addition, we may not be able to generate fakes for these classes, if generated subtypes of ProtobufEnum and GeneratedMessage become final. Which I have hopes for. See google/protobuf.dart#820