merge bitcoin#25292: Add LogPrintLevel to lint-format-strings, drop L…

…ogPrint-vs-LogPrintf section in dev notes
dashpay · Nov 20, 2024 · 32f9a03 · 32f9a03
1 parent 37ab275
commit 32f9a03
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/doc/developer-notes.md b/doc/developer-notes.md
@@ -862,11 +862,6 @@ int GetInt(Tabs tab)
 Strings and formatting
 ------------------------
 
-- Be careful of `LogPrint` versus `LogPrintf`. `LogPrint` takes a `category` argument, `LogPrintf` does not.
-
-  - *Rationale*: Confusion of these can result in runtime exceptions due to
-    formatting mismatch, and it is easy to get wrong because of subtly similar naming.
-
 - Use `std::string`, avoid C string manipulation functions.
 
   - *Rationale*: C++ string handling is marginally safer, less scope for

diff --git a/test/lint/lint-format-strings.sh b/test/lint/lint-format-strings.sh
@@ -17,6 +17,7 @@ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS=(
     "LogConnectFailure,1"
     "LogPrint,1"
     "LogPrintf,0"
+    "LogPrintLevel,2"
     "printf,0"
     "snprintf,2"
     "sprintf,1"